Commit 9a2146d
committed
fix(isaac): mirror real SimEngine abstract surface in fallback ABC
cagataycali's review comment on simulation.py:50 (#47) flagged that the
fallback ABC declared zero @AbstractMethod decorators, so
IsaacSimulation() instantiated cleanly in tests when strands-robots was
absent — masking the abstract-method gap that surfaces the moment the
real ABC is in scope.
Mirror the real strands_robots.simulation.base.SimEngine surface (14
abstract methods) in the fallback. Now `pytest` produces the same
failure mode (25 failed / 33 passed) whether strands-robots is installed
or not, including the dedicated canary
test_isaac_implements_all_abstract_methods. The 4 missing concrete
implementations on IsaacSimulation (list_robots, remove_robot,
remove_object, robot_joint_names) remain a separately tracked gap per
the PR body — this commit just makes the gap visible in CI.1 parent c63cde6 commit 9a2146d
1 file changed
Lines changed: 37 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
43 | 78 | | |
44 | 79 | | |
45 | 80 | | |
| |||
0 commit comments