Skip to content

Commit 152fc68

Browse files
committed
fix: pr comments
1 parent a718765 commit 152fc68

5 files changed

Lines changed: 344 additions & 93 deletions

File tree

docs/stories/04-components/Drawer.mdx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ Optional. Flex container for custom actions.
7979

8080
## Positions
8181

82-
The drawer can be positioned on any edge via the `side` prop.
82+
The drawer can be positioned on any edge via the `direction` prop (can be `left`, `right`, `top` or `bottom`).
83+
84+
The width will be forced at 100% on mobile devices.
8385

8486
## Header visible
8587

docs/stories/04-components/Drawer.stories.tsx

Lines changed: 49 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import * as React from 'react';
22

33
import { Meta, StoryObj } from '@storybook/react-vite';
4-
import { Button, Drawer, Field, Flex } from '@strapi/design-system';
4+
import { Button, Drawer, Field, Flex, Typography } from '@strapi/design-system';
55
import { outdent } from 'outdent';
66

77
interface DrawerArgs
88
extends Drawer.Props,
9-
Pick<Drawer.ContentProps, 'side' | 'width' | 'height' | 'maxWidth' | 'maxHeight' | 'padding'>,
9+
Pick<Drawer.ContentProps, 'direction' | 'width' | 'height' | 'maxWidth' | 'maxHeight' | 'padding'>,
1010
Pick<Drawer.HeaderProps, 'hasToggle' | 'hasClose'> {
1111
headerVisible?: boolean;
1212
overlayVisible?: boolean;
@@ -30,7 +30,7 @@ const meta: Meta<DrawerArgs> = {
3030
<Drawer.Trigger>
3131
<Button>Open drawer</Button>
3232
</Drawer.Trigger>
33-
<Drawer.Content side="right">
33+
<Drawer.Content direction="right">
3434
<Drawer.Header hasClose={hasClose} hasToggle={hasToggle}>
3535
<Drawer.Title>Drawer title</Drawer.Title>
3636
</Drawer.Header>
@@ -52,20 +52,20 @@ const meta: Meta<DrawerArgs> = {
5252
},
5353
args: {
5454
defaultOpen: false,
55-
side: 'right',
55+
direction: 'right',
5656
headerVisible: false,
5757
overlayVisible: true,
5858
hasClose: true,
5959
hasToggle: true,
6060
},
6161
argTypes: {
62-
side: {
62+
direction: {
6363
control: 'select',
6464
options: ['top', 'right', 'bottom', 'left'],
6565
},
6666
},
6767
render: ({
68-
side,
68+
direction,
6969
width,
7070
height,
7171
maxWidth,
@@ -85,7 +85,7 @@ const meta: Meta<DrawerArgs> = {
8585
</Drawer.Trigger>
8686
)}
8787
<Drawer.Content
88-
side={side}
88+
direction={direction}
8989
width={width}
9090
{...(height !== undefined && { height })}
9191
{...(maxWidth !== undefined && { maxWidth })}
@@ -96,10 +96,34 @@ const meta: Meta<DrawerArgs> = {
9696
<Drawer.Title>Drawer title</Drawer.Title>
9797
</Drawer.Header>
9898
<Drawer.Body>
99-
<Field.Root name="example">
100-
<Field.Label>Example field</Field.Label>
101-
<Field.Input placeholder="Type something…" />
102-
</Field.Root>
99+
<Typography>
100+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla molestie odio dui. Cras egestas ultrices
101+
pulvinar. Cras in pellentesque neque. Vestibulum imperdiet ex vitae felis lobortis, sed facilisis ligula
102+
laoreet. Proin iaculis molestie felis. Curabitur ultrices turpis nec rutrum facilisis. Suspendisse in
103+
ligula in est euismod feugiat. Proin vestibulum eros massa, et accumsan justo interdum dictum. Vestibulum
104+
sed varius urna. Ut pellentesque fermentum sodales. Suspendisse venenatis eros vitae lorem rutrum tempus.
105+
Suspendisse diam erat, semper gravida finibus et, tincidunt a erat. Curabitur placerat imperdiet urna, sit
106+
amet aliquet lorem rutrum sit amet. Aliquam et molestie nisl. Quisque at nisl et eros sollicitudin blandit
107+
bibendum ac augue. Quisque nec facilisis tortor. Nulla ex urna, scelerisque ultricies leo eget, iaculis
108+
laoreet ipsum. Suspendisse potenti. Sed eget porttitor lectus. Nullam in ipsum vel enim facilisis gravida.
109+
Duis posuere porttitor erat eu maximus. Morbi viverra tempus ante. Phasellus gravida ligula vel elit
110+
lacinia, ut finibus urna interdum. In cursus rhoncus accumsan. Cras at mattis massa. Mauris tempor ipsum
111+
quam. Integer augue eros, accumsan in ante nec, tincidunt ultrices nisl. Integer ut enim enim. Vivamus
112+
posuere metus et nibh pharetra, at bibendum dolor porttitor. Fusce iaculis eleifend lectus, ut rutrum
113+
sapien auctor et. In vitae risus lacus. Quisque ex mauris, venenatis vel nisi in, dictum suscipit tortor.
114+
Aliquam non justo cursus, dictum libero eget, viverra velit. Sed velit nisi, rutrum ut tempor et, ornare
115+
sit amet risus. Mauris ornare eleifend justo et viverra. Morbi feugiat nulla vitae sodales auctor. Donec
116+
laoreet quam nibh, vel mattis ligula venenatis et. Ut vel tempor eros. Suspendisse at est scelerisque,
117+
rutrum mi non, congue enim. Ut laoreet feugiat ante non lobortis. Vivamus convallis libero condimentum
118+
nisl pellentesque, quis feugiat nunc suscipit. Maecenas laoreet dui nec nisi placerat tincidunt. Integer
119+
elementum, mauris eu suscipit rutrum, lectus sapien porttitor odio, a egestas velit nibh in eros.
120+
Vestibulum eu quam eu lorem bibendum maximus. Sed ac commodo sapien. Suspendisse congue lacus id finibus
121+
auctor. Cras eu placerat leo. Pellentesque ut elit bibendum, auctor massa eget, mollis lacus. In porttitor
122+
semper ante, sed gravida metus porta id. In scelerisque neque non laoreet faucibus. Aenean molestie
123+
pellentesque leo quis pharetra. Nam sit amet dictum lacus. Fusce eget condimentum justo. Integer lacus
124+
lectus, sagittis non ultrices sit amet, hendrerit ac mi. Quisque non laoreet erat. Mauris nec nulla erat.
125+
Suspendisse potenti.
126+
</Typography>
103127
</Drawer.Body>
104128
<Drawer.Footer>
105129
<Drawer.Close>
@@ -132,36 +156,36 @@ export const DefaultOpen = {
132156
name: 'default open',
133157
} satisfies Story;
134158

135-
export const SideRight = {
159+
export const DirectionRight = {
136160
args: {
137161
defaultOpen: true,
138-
side: 'right',
162+
direction: 'right',
139163
},
140-
name: 'side right',
164+
name: 'direction right',
141165
} satisfies Story;
142166

143-
export const SideLeft = {
167+
export const DirectionLeft = {
144168
args: {
145169
defaultOpen: true,
146-
side: 'left',
170+
direction: 'left',
147171
},
148-
name: 'side left',
172+
name: 'direction left',
149173
} satisfies Story;
150174

151-
export const SideTop = {
175+
export const DirectionTop = {
152176
args: {
153177
defaultOpen: true,
154-
side: 'top',
178+
direction: 'top',
155179
},
156-
name: 'side top',
180+
name: 'direction top',
157181
} satisfies Story;
158182

159-
export const SideBottom = {
183+
export const DirectionBottom = {
160184
args: {
161185
defaultOpen: true,
162-
side: 'bottom',
186+
direction: 'bottom',
163187
},
164-
name: 'side bottom',
188+
name: 'direction bottom',
165189
} satisfies Story;
166190

167191
export const HeaderVisible = {
@@ -170,7 +194,7 @@ export const HeaderVisible = {
170194
source: {
171195
code: outdent`
172196
<Drawer.Root headerVisible defaultOpen={false}>
173-
<Drawer.Content side="bottom" width="100%" padding={0}>
197+
<Drawer.Content direction="bottom" width="100%" padding={0}>
174198
<Drawer.Header hasToggle={false}>
175199
<Drawer.Title>Drawer title</Drawer.Title>
176200
</Drawer.Header>
@@ -192,7 +216,7 @@ export const HeaderVisible = {
192216
args: {
193217
defaultOpen: false,
194218
headerVisible: true,
195-
side: 'bottom',
219+
direction: 'bottom',
196220
width: '100%',
197221
padding: 0,
198222
},

0 commit comments

Comments
 (0)