Constrained composite fields refac#1400
Merged
Merged
Conversation
fabiomadge
approved these changes
Jun 22, 2026
Contributor
There was a problem hiding this comment.
Behavior-preserving refactor, verified end-to-end (544 green): the unified resultUsed-aware traversal reproduces the old elimStmt/wrapExprAssigns split — statement and expression-position assigns both correct, field double-eval fix intact (RHS evaluated once), field constraint type detected via computeExprType. Nice simplification; resolves the mapStmtExpr/catch-all point. (Supplementary to @olivier-aws's review.)
Contributor
|
LGTM, thanks for the refactor. |
olivier-aws
merged commit d7bb6b0
into
strata-org:pr-constrained-composite-fields-main2
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constrained composite fields refactoring