Skip to content

Commit 2a54e55

Browse files
committed
fix unit tests
1 parent 4126f3b commit 2a54e55

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

modules/fides/messaging/network_bridge.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,19 @@ def listen(self, handler: MessageHandler, block: bool = False):
3939
def message_received(message: str):
4040
"""this is the callback that executes every new msg"""
4141
try:
42-
with open("/tmp/fides_nb.txt", "a") as f:
43-
f.write(f"message: {message}\n")
4442

4543
logger.debug("New message received! Trying to parse.")
4644
parsed = json.loads(message)
4745
network_message = from_dict(
4846
data_class=NetworkMessage, data=parsed
4947
)
5048

51-
with open("/tmp/fides_nb.txt", "a") as f:
52-
f.write(f"network_message: {network_message}\n")
53-
5449
logger.debug("Message parsed. Executing handler.")
5550
handler.on_message(network_message)
5651
except Exception as e:
5752
logger.error(
5853
f"There was an error processing message, Exception: {e}."
5954
)
60-
with open("/tmp/fides_nb.txt", "a") as f:
61-
f.write(f"there was an error processing message | {e}\n")
6255
handler.on_error(message, e)
6356

6457
logger.debug("Starts listening...")

tests/module_factory.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@ def create_fides_obj(self, mock_db):
151151
from modules.fides.fides import FidesModule
152152

153153
db_path = os.path.join("permanent", "databases", "fides_p2p_db.sqlite")
154+
config_path = os.path.join(
155+
"modules", "fides", "config", "fides.conf.yml"
156+
)
154157

155158
def get_permanent_database_path(_filename):
156159
os.makedirs(os.path.dirname(db_path), exist_ok=True)
@@ -159,14 +162,16 @@ def get_permanent_database_path(_filename):
159162
mock_db.return_value.get_permanent_database_path.side_effect = (
160163
get_permanent_database_path
161164
)
165+
conf = Mock()
166+
conf.read_configuration = Mock(return_value=config_path)
162167

163168
fm = FidesModule(
164169
logger=self.logger,
165170
output_dir="dummy_output_dir",
166171
redis_port=6379,
167172
termination_event=Mock(),
168173
slips_args=Mock(),
169-
conf=Mock(),
174+
conf=conf,
170175
ppid=Mock(),
171176
bloom_filters_manager=Mock(),
172177
)

0 commit comments

Comments
 (0)