Skip to content

adding new ML modules for slips #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsvobo wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

adding new ML modules for slips #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e9782f9
add LFS tracking rules for artifacts folders
jsvobo Mar 26, 2026
580bbe4
adding ML modules, the base class and models they use (selected one b…
jsvobo Mar 26, 2026
5b4ec44
ML module base class, template for new modules in common. config pars…
jsvobo Mar 26, 2026
79d24fc
unit-tests for all new modules and base class
jsvobo Mar 26, 2026
ef27f82
docs for new modules, river in install, training directions
jsvobo Mar 26, 2026
bfcfa50
solve problems with parsing .labeled file names?
jsvobo Mar 26, 2026
a869905
updated model, it was the bad sgt one
jsvobo Mar 26, 2026
83de078
now fetching via LFS for integration tests
jsvobo Mar 26, 2026
d674cdf
now fetching via LFS for integration tests
jsvobo Mar 26, 2026
301005c
updated yaml with all configs for running new ml models
jsvobo Mar 26, 2026
b445389
debugged 5 problems in models. not recognising loaded scaler, bad fea…
jsvobo Mar 26, 2026
6ab651d
broader definition of BG label to catch different versions
jsvobo Mar 26, 2026
a819b0d
added common functions to base ml class
jsvobo Mar 27, 2026
c11d561
update branch with the latest develop
AlyaGomaa Mar 30, 2026
0a0b38b
ml_module_base.py: close log_file on shutdown
AlyaGomaa Mar 30, 2026
587fb95
Merge remote-tracking branch 'origin/develop' into ml_modules_refactor
AlyaGomaa Apr 1, 2026
5c6ca2c
moved ml template into the proper place
jsvobo Apr 12, 2026
31878dc
updated docs on new modules to reflect ML module creation + adding ne…
jsvobo Apr 12, 2026
7d3da71
updated readme and removed env variables from modules
jsvobo Apr 12, 2026
1f99ea4
unit tests for the new ml modules updated --> removed unused variable…
jsvobo Apr 12, 2026
584445e
new evidence types for each ml module
jsvobo Apr 12, 2026
7220daa
secret baseline regenerated
jsvobo Apr 13, 2026
1671128
Merge branch 'develop' into ml_modules_refactor
jsvobo Apr 13, 2026
e36a487
Add logs for each step of the evidence handle shutdown_gracefully()
AlyaGomaa Apr 14, 2026
f19b683
Merge remote-tracking branch 'origin/develop' into alya/fix_flaky_sto…
AlyaGomaa Apr 14, 2026
08ca88e
Merge remote-tracking branch 'origin/develop' into ml_modules_refactor
AlyaGomaa Apr 14, 2026
ac5cc81
temporarily disable integration tests output dir cleanup to be able t…
AlyaGomaa Apr 14, 2026
6aaa25f
Merge remote-tracking branch 'origin/ml_modules_refactor' into alya/f…
AlyaGomaa Apr 14, 2026
685b067
Fix github CI uploading the wrong integration tests output dir
AlyaGomaa Apr 14, 2026
0875b91
log the number of started profiler workers the input process is sendi…
AlyaGomaa Apr 14, 2026
f0af1d4
separated evidence descriptions, now for module unique
jsvobo Apr 15, 2026
4737bcf
let profiler.py handle the shutdown of all the profiler workers
AlyaGomaa Apr 15, 2026
8c5be25
update unit tests
AlyaGomaa Apr 15, 2026
ceb6be8
Merge remote-tracking branch 'origin/alya/fix_flaky_stopping_of_slips…
AlyaGomaa Apr 15, 2026
9e18e63
test_Dataset: cleanup the output dir when tests are done
AlyaGomaa Apr 15, 2026
4303cbd
normalizing labels inside module base
jsvobo Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
modules/ml_linear_model/artifacts/* filter=lfs diff=lfs merge=lfs -text
modules/ml_online_model/artifacts/* filter=lfs diff=lfs merge=lfs -text
10 changes: 9 additions & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,18 @@ jobs:
test_file: ${{ fromJson(needs.list-integration-tests.outputs.test_files) }}

steps:

- name: Install Git LFS
run: |
apt-get update -qq
apt-get install -y git-lfs
git lfs install

- uses: actions/checkout@v5
with:
ref: ${{ github.ref }}
fetch-depth: 0
lfs: true

- name: Start Redis
uses: ./.github/actions/start-redis
Expand All @@ -60,4 +68,4 @@ jobs:
# Replaces slashes with underscores for valid artifact naming
name: ${{ github.run_id }}-${{ strategy.job-index }}-integration-output
path: |
output/integration
output/integration_tests
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ repos:
args: ['--line-length' , '79']
language_version: python3.12.3
# excludes formatting slips_files/common/imports.py
exclude: (imports|conftest.py|tests/*.py)
exclude: (imports|conftest\.py|^tests/.*\.py$)

- repo: https://github.com/adrienverge/yamllint.git
rev: v1.35.1
Expand Down
Loading
Loading