Merge pull request #1771 from crimx/patch-3

fix useUnmountPromise stops when component is updated

Author: xobotyi

src/useUnmountPromise.ts

@@ -1,10 +1,11 @@
-import { useEffect, useMemo, useRef } from 'react';
+import { useMemo, useRef } from 'react';
+import useEffectOnce from './useEffectOnce';
 
 export type Race = <P extends Promise<any>, E = any>(promise: P, onError?: (error: E) => void) => P;
 
 const useUnmountPromise = (): Race => {
   const refUnmounted = useRef(false);
-  useEffect(() => () => {
+  useEffectOnce(() => () => {
     refUnmounted.current = true;
   });
 

tests/useUnmountPromise.test.ts

@@ -35,6 +35,19 @@ describe('useUnmountPromise', () => {
     ]);
     expect(res).toBe('UNMOUNTED');
   });
+  
+  it('should resolve promise when component is updated', async () => {
+    const hook = renderHook(() => useUnmountPromise());
+
+    const mounted = hook.result.current;
+    const pRes = mounted(new Promise(r => setTimeout(() => r(25), 10)));
+    
+    hook.rerender();
+    
+    const res = await pRes;
+
+    expect(res).toBe(25);
+  });
 
   it('when component is mounted function should resolve with wrapped promises - 2', async () => {
     const hook = renderHook(() => useUnmountPromise());