AI highlighter toggle fix and update games.#5930
Open
michelinewu wants to merge 5 commits into
Open
Conversation
gettinToasty
approved these changes
May 20, 2026
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +304B 0% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Highlighter Toggle Fix, Game Selector Name Sync, and Supported Games Updates
Issues
AI Highlighter Toggle not responding to game selection:
AiHighlighterTogglewas receivingbind.game?.value, which holds the game's internal ID/slug, instead ofbind.gameName?.value, which holds the human-readable game name. Because the toggle uses the game name to look up AI highlighter support, it was never activating correctly when a game was selected.AI Highlighter Toggle not updating when game name changes:
Even after fixing the prop passed to
AiHighlighterToggle, thegameNamestate was never updated when the user selected a game inGameSelector.GameSelectoronly calledonSelectwith the internal value; the display name was silently discarded. As a result,bind.gameName.valueremained stale (empty/undefined) and the toggle always received no game name.Supported games tooltip overflows on small screens:
The "supported games" tooltip in
SupportedGameshad no maximum height or scroll, so when many games were listed the tooltip could overflow the viewport with no way to scroll.Flaky performance metrics test:
The test read CPU usage immediately after opening the stats window. On app start, CPU usage is initialized to
0to avoidNaN, so the assertioncpuUsage > 0could fail before the first real value arrived.Fixes
TwitchEditStreamInfo.tsx— ChangedAiHighlighterToggle'sgameprop frombind.game?.valuetobind.gameName?.valueso the toggle receives the display name instead of the internal game ID.GameSelector.tsx— Added an optionalonNameChangecallback toTProps. When the user picks a game, the callback fires withopts.label(the display name), allowing consumers to keep a separate name binding in sync.TwitchEditStreamInfo.tsx— WiredonNameChange={bind.gameName.onChange}intoGameSelectorsogameNamestate is updated on every game selection.SupportedGames.tsx— Wrapped the tooltip content in<Scrollable style={{ maxHeight: '80vh' }}>so the game list scrolls instead of overflowing.game-config.models.ts/ai-highlighter.models.ts— Added 3 new supported games to the AI Highlighter game list.test/regular/performance-metrics.ts— Added awaitUntilpoll before reading CPU usage so the test waits for a non-zero value (up to 10 s) rather than snapshotting the initial0.