Skip to content

AI highlighter toggle fix and update games.#5930

Open
michelinewu wants to merge 5 commits into
masterfrom
mw_fix_tw_games
Open

AI highlighter toggle fix and update games.#5930
michelinewu wants to merge 5 commits into
masterfrom
mw_fix_tw_games

Conversation

@michelinewu
Copy link
Copy Markdown
Contributor

@michelinewu michelinewu commented May 20, 2026

AI Highlighter Toggle Fix, Game Selector Name Sync, and Supported Games Updates

Issues

AI Highlighter Toggle not responding to game selection:
AiHighlighterToggle was receiving bind.game?.value, which holds the game's internal ID/slug, instead of bind.gameName?.value, which holds the human-readable game name. Because the toggle uses the game name to look up AI highlighter support, it was never activating correctly when a game was selected.

AI Highlighter Toggle not updating when game name changes:
Even after fixing the prop passed to AiHighlighterToggle, the gameName state was never updated when the user selected a game in GameSelector. GameSelector only called onSelect with the internal value; the display name was silently discarded. As a result, bind.gameName.value remained stale (empty/undefined) and the toggle always received no game name.

Supported games tooltip overflows on small screens:
The "supported games" tooltip in SupportedGames had no maximum height or scroll, so when many games were listed the tooltip could overflow the viewport with no way to scroll.

Flaky performance metrics test:
The test read CPU usage immediately after opening the stats window. On app start, CPU usage is initialized to 0 to avoid NaN, so the assertion cpuUsage > 0 could fail before the first real value arrived.

Fixes

  • TwitchEditStreamInfo.tsx — Changed AiHighlighterToggle's game prop from bind.game?.value to bind.gameName?.value so the toggle receives the display name instead of the internal game ID.
  • GameSelector.tsx — Added an optional onNameChange callback to TProps. When the user picks a game, the callback fires with opts.label (the display name), allowing consumers to keep a separate name binding in sync.
  • TwitchEditStreamInfo.tsx — Wired onNameChange={bind.gameName.onChange} into GameSelector so gameName state is updated on every game selection.
  • SupportedGames.tsx — Wrapped the tooltip content in <Scrollable style={{ maxHeight: '80vh' }}> so the game list scrolls instead of overflowing.
  • game-config.models.ts / ai-highlighter.models.ts — Added 3 new supported games to the AI Highlighter game list.
  • test/regular/performance-metrics.ts — Added a waitUntil poll before reading CPU usage so the test waits for a non-zero value (up to 10 s) rather than snapshotting the initial 0.

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented May 20, 2026

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
7.77MB (+304B 0%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.67MB -
updater.js
115.29KB -
guest-api.js
40.23KB -

Total files change +304B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants