Using new API for obtaining encoder metadata from OSN#5931
Open
aleksandr-voitenko wants to merge 8 commits into
Open
Using new API for obtaining encoder metadata from OSN#5931aleksandr-voitenko wants to merge 8 commits into
aleksandr-voitenko wants to merge 8 commits into
Conversation
e8ac528 to
8b05775
Compare
BundleMonFiles added (4)
Total files change +12.59MB Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves Desktop encoder resolution to the backend-owned encoder metadata exposed by
obs-studio-node#getAvailableEncoders()instead of relying on Desktop’s hand-maintained advanced encoder ID list.Motivation
Desktop was treating encoder IDs as a closed, duplicated list. When OSN added or changed encoder IDs, Desktop could fail to resolve metadata and either omit
videoEncoderor throw during settings resolution, causing invalid/unknown encoder errors for streaming and recording.Changes
EncoderQueryServicemetadata helpers for streaming and recording encoders:idfamilyqsv,amd,x264amd_amf_h264 -> h264_texture_amfobs_qsv11 -> obs_qsv11_v2qsvandamddo not conflate H.264/HEVC/AV1 profiles.Bonus
A bunch of encoder conversion bugs were fixed and covered by tests.