feat(widgets): port jar to react#5957
Open
wesrupert wants to merge 3 commits into
Open
Conversation
BundleMonFiles added (4)
Total files change +12.65MB Final result: ✅ View report in BundleMon website ➡️ |
gettinToasty
approved these changes
Jun 11, 2026
| } | ||
| >; | ||
| }; | ||
| } |
| SK extends keyof SO, | ||
| K extends keyof TJarWidgetSettings, | ||
| SV extends Required<SO>[SK] | ||
| >(source: SO, sourceKey: SK, settingsKey: K, defaultValue: SV) { |
Contributor
There was a problem hiding this comment.
this is really hard to grok i think
Contributor
There was a problem hiding this comment.
seems you didnt end up using the Flatten or JoinKeys types you defined?
wesrupert
force-pushed
the
feat/wr/credits/dev
branch
from
July 7, 2026 21:02
d62a6b2 to
f3aecd8
Compare
wesrupert
force-pushed
the
feat/wr/jar/dev
branch
from
July 7, 2026 21:02
799178a to
e9c20e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settingstype (half of the widgets already didn't trust the current type)