Skip to content

Commit 12508dc

Browse files
committed
do not check for default output audio on virtual mac CI
1 parent adf2c8e commit 12508dc

3 files changed

Lines changed: 10 additions & 1 deletion

File tree

.github/workflows/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ jobs:
151151
OSN_ACCESS_KEY_ID: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}}
152152
OSN_SECRET_ACCESS_KEY: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}}
153153
RELEASE_NAME: ${{matrix.ReleaseName}}
154+
CI: true
154155
# Run even after test failures so the PR still gets the flaky summary.
155156
- name: Publish flaky test check
156157
if: ${{ always() }}

tests/osn-tests/src/test_osn_audio.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ describe(testName, () => {
7070
foundDefaultDevice = true;
7171
}
7272
}
73-
expect(foundDefaultDevice).to.equal(true, GetErrorMessage(ETestErrorMsg.DefaultDeviceNotFound));
73+
if (!obs.isOnDarwinCI()) { // On virtual mac(s) the default output device is not included in the list of output devices
74+
expect(foundDefaultDevice).to.equal(true, GetErrorMessage(ETestErrorMsg.DefaultDeviceNotFound));
75+
}
7476
});
7577

7678
it('Get input audio devices', function() {

tests/osn-tests/util/obs_handler.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -557,6 +557,12 @@ export class OBSHandler {
557557
return this.os === 'darwin';
558558
}
559559

560+
isOnDarwinCI()
561+
{
562+
// Wrapped this in a function- just incase we want to add more conditions later or disable only within the build agent.
563+
return this.os === 'darwin' && this.ci;
564+
}
565+
560566
// is the build server environment
561567
isCI()
562568
{

0 commit comments

Comments
 (0)