Revert "osn-replay-buffer: invoke output handler to save replays (#1689)"

This reverts commit e0d4c05.

This implementation overwrites the file (release blocker)

Author: sandboxcoder

obs-studio-server/source/osn-replay-buffer.cpp

@@ -152,23 +152,19 @@ void osn::IReplayBuffer::Query(void *data, const int64_t id, const std::vector<i
 
 void osn::IReplayBuffer::Save(void *data, const int64_t id, const std::vector<ipc::value> &args, std::vector<ipc::value> &rval)
 {
-	ReplayBuffer *replayBuffer = static_cast<ReplayBuffer *>(osn::IFileOutput::Manager::GetInstance().find(args[0].value_union.ui64));
-	if (!replayBuffer) {
-		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "ReplayBuffer reference is not valid.");
-	}
+	obs_enum_hotkeys(
+		[](void *data, obs_hotkey_id id, obs_hotkey_t *key) {
+			if (obs_hotkey_get_registerer_type(key) == OBS_HOTKEY_REGISTERER_OUTPUT) {
+				std::string key_name = obs_hotkey_get_name(key);
+				if (key_name.compare("ReplayBuffer.Save") == 0) {
+					obs_hotkey_enable_callback_rerouting(true);
+					obs_hotkey_trigger_routed_callback(id, true);
+				}
+			}
+			return true;
+		},
+		nullptr);
 
-	obs_output_t *output = replayBuffer->GetOutput();
-	if (!output) {
-		PRETTY_ERROR_RETURN(ErrorCode::InvalidReference, "Invalid replay buffer output.");
-	}
-
-	calldata_t cd = {0};
-	proc_handler_t *ph = obs_output_get_proc_handler(output);
-	bool hasInvoked = proc_handler_call(ph, "save", &cd);
-	calldata_free(&cd);
-
-	if (!hasInvoked)
-		PRETTY_ERROR_RETURN(ErrorCode::NotFound, "Could not find ReplayBuffer::Save");
 	rval.push_back(ipc::value((uint64_t)ErrorCode::Ok));
 	AUTO_DEBUG;
-}
+}

tests/osn-tests/src/test_osn_advanced_replayBuffer.ts

@@ -131,6 +131,9 @@ describe(testName, () => {
     });
 
     it('Start advanced replay buffer - Use Recording', async function() {
+        if (obs.isDarwin()) {
+            this.skip();
+        }
         replayBuffer = osn.AdvancedReplayBufferFactory.create();
         replayBuffer.path = path.join(path.normalize(__dirname), '..', 'osnData');
         replayBuffer.format = osn.ERecordingFormat.MP4;
@@ -258,6 +261,9 @@ describe(testName, () => {
     });
 
     it('Start advanced replay buffer - Use Stream through Recording', async function() {
+        if (obs.isDarwin()) {
+            this.skip();
+        }
         replayBuffer = osn.AdvancedReplayBufferFactory.create();
         replayBuffer.path = path.join(path.normalize(__dirname), '..', 'osnData');
         replayBuffer.format = osn.ERecordingFormat.MP4;