add isDarwinCI() and cleanup test cases

Author: sandboxcoder

.github/workflows/main.yml

@@ -151,6 +151,7 @@ jobs:
           OSN_ACCESS_KEY_ID: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}}
           OSN_SECRET_ACCESS_KEY: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}}
           RELEASE_NAME: ${{matrix.ReleaseName}}
+          CI: true
       # Run even after test failures so the PR still gets the flaky summary.
       - name: Publish flaky test check
         if: ${{ always() }}

tests/osn-tests/src/test_osn_audio.ts

@@ -66,11 +66,14 @@ describe(testName, () => {
         for (const device of devices) {
             expect(device).to.have.property('id');
             expect(device).to.have.property('description');
+            logInfo(testName, `Output Audio Device Found: ${device.description} with id: ${device.id}`);
             if (device.id === 'default') {
                 foundDefaultDevice = true;
             }
         }
-        expect(foundDefaultDevice).to.equal(true, GetErrorMessage(ETestErrorMsg.DefaultDeviceNotFound));
+        if (!obs.isDarwinCI()) { // On virtual mac(s) the default output device is not included in the list of output devices
+            expect(foundDefaultDevice).to.equal(true, GetErrorMessage(ETestErrorMsg.DefaultDeviceNotFound));
+        }
     });
 
     it('Get input audio devices', function() {
@@ -81,6 +84,7 @@ describe(testName, () => {
         for (const device of devices) {
             expect(device).to.have.property('id');
             expect(device).to.have.property('description');
+            logInfo(testName, `Input Audio Device Found: ${device.description} with id: ${device.id}`);
             if (device.id === 'default') {
                 foundDefaultDevice = true;
             }

tests/osn-tests/src/test_osn_video.ts

@@ -201,5 +201,8 @@ describe(testName, () => {
             expect(device).to.have.property('description');
             logInfo(testName, `Output Video Device Found: ${device.description} with id: ${device.id}`);
         }
+        if (!obs.isCI()) { // On CI the list of video devices is empty since there is no GPU. Just check that we got an array back and not worry about the contents
+            expect(devices.length).to.be.greaterThan(0, GetErrorMessage(ETestErrorMsg.VideoDevicesEmpty));
+        }
     });
 });

tests/osn-tests/util/error_messages.ts

@@ -205,6 +205,7 @@ export const enum ETestErrorMsg {
     DefaultDeviceNotFound = 'Did not find the default audio device in the list of audio devices',
     VideoDevices = 'Failed to get video devices',
     VideoDevicesIsArray = 'Returned video devices value is not an array',
+    VideoDevicesEmpty = 'Returned video devices array is empty',
 }
 
 export function GetErrorMessage(message: string, value1?: string, value2?: string, value3?: string): string {

tests/osn-tests/util/obs_handler.ts

@@ -553,10 +553,16 @@ export class OBSHandler {
 
     isDarwin()
     {
-        // Wrapped this in a function- just incase we want to add more conditions later or disable only within the build agent.
+        // Wrapped this in a function- just in case we want to add more conditions later or disable only within the build agent.
         return this.os === 'darwin';
     }
 
+    isDarwinCI()
+    {
+        // Wrapped this in a function- just in case we want to add more conditions later or disable only within the build agent.
+        return this.os === 'darwin' && this.ci;
+    }
+
     // is the build server environment
     isCI()
     {