use OBSDataAutoRelease (RAII) to release resources

Author: sandboxcoder

obs-studio-server/source/nodeobs_settings.cpp

@@ -3868,7 +3868,7 @@ void OBS_settings::saveGenericSettings(std::vector<SubCategory> genericSettings,
 
 void getDevices(const char *source_id, const char *property_name, std::vector<ipc::value> &rval)
 {
-	auto settings = obs_get_source_defaults(source_id);
+	OBSDataAutoRelease settings = obs_get_source_defaults(source_id);
 	if (!settings)
 		return;
 
@@ -3881,7 +3881,6 @@ void getDevices(const char *source_id, const char *property_name, std::vector<ip
 
 	auto props = obs_get_source_properties(source_id);
 	if (!props) {
-		obs_data_release(settings);
 		blog(LOG_WARNING, "Could not get source properties for source id: %s", source_id);
 		return;
 	}
@@ -3890,7 +3889,6 @@ void getDevices(const char *source_id, const char *property_name, std::vector<ip
 	if (!prop) {
 		blog(LOG_WARNING, "Could not get the property [%s] for source id: %s", property_name, source_id);
 		obs_properties_destroy(props);
-		obs_data_release(settings);
 		return;
 	}
 
@@ -3914,7 +3912,6 @@ void getDevices(const char *source_id, const char *property_name, std::vector<ip
 	}
 
 	obs_properties_destroy(props);
-	obs_data_release(settings);
 }
 
 #ifdef WIN32