address PR review feedback on generated JS surface

CI: make ci/check-js-generated.sh fail-fast (set -euo pipefail) so a
failing git invocation can no longer leave `dirty` empty and pass
silently; drop the no-op `set +x`.

module.ts typing accuracy (verified against obs-studio-client/source):
- IProperty.next()/previous() and IProperties.first()/last()/get() return
  undefined at end-of-list / empty / not-found, so type them
  `IProperty | undefined`; fix the stale next() JSDoc and get() "null".
- Move sendMessage() from ISource to IInput — only Input registers it
  natively (input.cpp); Filter/Scene/Transition do not.
- Hoist load() to the ISource base (registered on Input/Filter/Scene/
  Transition) and drop the per-interface duplicates; IFilter now gets it.
- IModuleFactory.modules() returns primitive strings -> string[].
- IModule.initialize() returns a boolean natively, not void.

Remove stray trailing `;` after enum/interface blocks so the generated
module.js no longer emits empty statements.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: summeroff

ci/check-js-generated.sh

@@ -2,9 +2,10 @@
 # Verify that the committed tsc outputs under js/ match what regenerating
 # from js/module.ts would produce. CI runs `yarn build:javascript` first,
 # so any change under js/ at this point is a stale generated file.
+set -euo pipefail
+
 dirty=$(git status --porcelain -- js/)
 
-set +x
 if [[ $dirty ]]; then
 	echo "================================================="
 	echo "Generated JS files are stale. Run locally:"

js/module.d.ts

@@ -426,17 +426,17 @@ export interface IProperty {
     readonly visible: boolean;
     readonly type: EPropertyType;
     readonly value: any;
-    next(): IProperty;
-    previous(): IProperty;
+    next(): IProperty | undefined;
+    previous(): IProperty | undefined;
     is_first(): boolean;
     is_last(): boolean;
     modified(): boolean;
 }
 export interface IProperties {
-    first(): IProperty;
-    last(): IProperty;
+    first(): IProperty | undefined;
+    last(): IProperty | undefined;
     count(): number;
-    get(name: string): IProperty;
+    get(name: string): IProperty | undefined;
 }
 export interface IFactoryTypes {
     types(): string[];
@@ -531,7 +531,7 @@ export interface IInput extends ISource {
     restart(): void;
     stop(): void;
     getMediaState(): number;
-    load(): void;
+    sendMessage(message: ISettings): void;
 }
 export interface ISceneFactory {
     create(name: string): IScene;
@@ -548,7 +548,6 @@ export interface IScene extends ISource {
     getItemAtIdx(idx: number): ISceneItem;
     getItems(): ISceneItem[];
     getItemsInRange(fromIndex: number, toIndex: number): ISceneItem[];
-    load(): void;
     sendMouseClick(eventData: IMouseEvent, type: EMouseButtonType, mouseUp: boolean, clickCount: number): void;
     sendMouseMove(eventData: IMouseEvent, mouseLeave: boolean): void;
     sendMouseWheel(eventData: IMouseEvent, x_delta: number, y_delta: number): void;
@@ -595,7 +594,6 @@ export interface ITransition extends ISource {
     clear(): void;
     set(input: ISource): void;
     start(ms: number, input: ISource): void;
-    load(): void;
     sendMouseClick(eventData: IMouseEvent, type: EMouseButtonType, mouseUp: boolean, clickCount: number): void;
     sendMouseMove(eventData: IMouseEvent, mouseLeave: boolean): void;
     sendMouseWheel(eventData: IMouseEvent, x_delta: number, y_delta: number): void;
@@ -611,7 +609,7 @@ export interface IConfigurable {
 export interface ISource extends IConfigurable, IReleasable {
     remove(): void;
     save(): void;
-    sendMessage(message: ISettings): void;
+    load(): void;
     readonly status: number;
     readonly type: ESourceType;
     readonly id: string;
@@ -686,10 +684,10 @@ export interface IAudioFactory {
 }
 export interface IModuleFactory {
     open(binPath: string, dataPath: string): IModule;
-    modules(): String[];
+    modules(): string[];
 }
 export interface IModule {
-    initialize(): void;
+    initialize(): boolean;
     readonly fileName: string;
     readonly name: string;
     readonly author: string;

js/module.js

@@ -383,16 +383,12 @@ var EInteractionFlags;
     EInteractionFlags[EInteractionFlags["IsLeft"] = 1024] = "IsLeft";
     EInteractionFlags[EInteractionFlags["IsRight"] = 2048] = "IsRight";
 })(EInteractionFlags || (exports.EInteractionFlags = EInteractionFlags = {}));
-;
 var EMouseButtonType;
 (function (EMouseButtonType) {
     EMouseButtonType[EMouseButtonType["Left"] = 0] = "Left";
     EMouseButtonType[EMouseButtonType["Middle"] = 1] = "Middle";
     EMouseButtonType[EMouseButtonType["Right"] = 2] = "Right";
 })(EMouseButtonType || (exports.EMouseButtonType = EMouseButtonType = {}));
-;
-;
-;
 function addItems(scene, sceneItems) {
     const items = [];
     if (Array.isArray(sceneItems)) {
@@ -502,7 +498,6 @@ var VCamOutputType;
     VCamOutputType[VCamOutputType["ProgramView"] = 3] = "ProgramView";
     VCamOutputType[VCamOutputType["PreviewOutput"] = 4] = "PreviewOutput";
 })(VCamOutputType || (exports.VCamOutputType = VCamOutputType = {}));
-;
 const appleBinaryFolder = hasDeveloperApp
     ? path.join(__dirname, 'OSN.app', 'distribute', 'obs-studio-node', 'bin')
     : path.join(__dirname, 'bin');

js/module.ts

@@ -697,19 +697,16 @@ export interface IProperty {
     readonly value: any;
 
     /**
-     * Uses the current object to obtain the next
-     * property in the properties list.
-     *
-     * @returns If it's successful, returns true.
-     * Otherwise or if end of the list, returns false.
+     * Uses the current object to obtain the next property in the list.
+     * @returns The next property, or undefined at the end of the list.
      */
-    next(): IProperty;
+    next(): IProperty | undefined;
 
     /**
      * Uses the current object to obtain the previous property in the list.
-     * Returns undefined when the current property is the first.
+     * @returns The previous property, or undefined when the current property is the first.
      */
-    previous(): IProperty;
+    previous(): IProperty | undefined;
 
     /** True when this property is the first in the list. */
     is_first(): boolean;
@@ -728,20 +725,20 @@ export interface IProperty {
  */
 export interface IProperties {
 
-    /** Obtains the first property in the list. */
-    first(): IProperty;
+    /** Obtains the first property in the list, or undefined when the list is empty. */
+    first(): IProperty | undefined;
 
-    /** Obtains the last property in the list. */
-    last(): IProperty;
+    /** Obtains the last property in the list, or undefined when the list is empty. */
+    last(): IProperty | undefined;
 
     count(): number;
 
     /**
      * Obtains property matching name.
      * @param name The name of the property to fetch.
-     * @returns - The property instance or null if not found
+     * @returns - The property instance, or undefined if not found
      */
-    get(name: string): IProperty;
+    get(name: string): IProperty | undefined;
 }
 
 export interface IFactoryTypes {
@@ -819,27 +816,27 @@ export enum EInteractionFlags {
 	IsKeyPad     = 1 << 9,
 	IsLeft       = 1 << 10,
 	IsRight      = 1 << 11
-};
+}
 
 export enum EMouseButtonType {
 	Left,
 	Middle,
 	Right
-};
+}
 
 export interface IMouseEvent {
 	modifiers: EInteractionFlags;
 	x: number;
 	y: number;
-};
+}
 
 export interface IKeyEvent {
 	modifiers: EInteractionFlags;
 	text: string;
 	nativeModifiers: number;
 	nativeScancode: number;
 	nativeVkey: number;
-};
+}
 
 export interface ISceneItemInfo {
     name: string,
@@ -976,9 +973,9 @@ export interface IInput extends ISource {
     getMediaState(): number;
 
     /**
-     * Re-trigger the source's load step (re-reads serialized state on the server).
+     * Forward a serializable message to the underlying source plugin.
      */
-    load(): void;
+    sendMessage(message: ISettings): void;
 }
 
 export interface ISceneFactory {
@@ -1074,11 +1071,6 @@ export interface IScene extends ISource {
      */
     getItemsInRange(fromIndex: number, toIndex: number): ISceneItem[];
 
-    /**
-     * Re-trigger the scene's load step on the server.
-     */
-    load(): void;
-
     sendMouseClick(eventData: IMouseEvent, type: EMouseButtonType, mouseUp: boolean, clickCount: number): void;
     sendMouseMove(eventData: IMouseEvent, mouseLeave: boolean): void;
     sendMouseWheel(eventData: IMouseEvent, x_delta: number, y_delta: number): void;
@@ -1241,11 +1233,6 @@ export interface ITransition extends ISource {
      */
     start(ms: number, input: ISource): void;
 
-    /**
-     * Re-trigger the transition's load step on the server.
-     */
-    load(): void;
-
     sendMouseClick(eventData: IMouseEvent, type: EMouseButtonType, mouseUp: boolean, clickCount: number): void;
     sendMouseMove(eventData: IMouseEvent, mouseLeave: boolean): void;
     sendMouseWheel(eventData: IMouseEvent, x_delta: number, y_delta: number): void;
@@ -1295,11 +1282,9 @@ export interface ISource extends IConfigurable, IReleasable {
     save(): void;
 
     /**
-     * Forward a serializable message to the underlying source plugin.
-     * Note: only registered on input sources on the native side; calling on
-     * a filter, scene, or transition will throw at runtime.
+     * Re-trigger the source's load step on the server.
      */
-    sendMessage(message: ISettings): void;
+    load(): void;
 
     /**
      * The validity of the source
@@ -1498,11 +1483,11 @@ export interface IAudioFactory {
 
 export interface IModuleFactory {
     open(binPath: string, dataPath: string): IModule;
-    modules(): String[];
+    modules(): string[];
 }
 
 export interface IModule {
-    initialize(): void;
+    initialize(): boolean;
     readonly fileName: string;
     readonly name: string;
     readonly author: string;
@@ -1927,7 +1912,7 @@ export enum VCamOutputType {
 	SourceOutput,
 	ProgramView,
 	PreviewOutput,
-};
+}
 
 // Initialization and other stuff which needs local data.
 const appleBinaryFolder = hasDeveloperApp