Fixed enhanced broadcasting crash for unsupported GPU (#1674)

* Fixed enhanced broadcasting crash for unsupported GPU

* Minor comment update

* Test fix

Author: aleksandr-voitenko

obs-studio-server/source/osn-enhanced-broadcasting-advanced-streaming.cpp

@@ -23,6 +23,7 @@
 #include "shared.hpp"
 #include "nodeobs_audio_encoders.h"
 #include "osn-audio-track.hpp"
+#include <exception>
 #include <osn-video.hpp>
 
 void osn::IEnhancedBroadcastingAdvancedStreaming::Register(ipc::server &srv)
@@ -118,7 +119,13 @@ void osn::IEnhancedBroadcastingAdvancedStreaming::Start(void *data, const int64_
 	}
 
 	auto vod_track_mixer = (streaming->twitchVODSupported && streaming->enableTwitchVOD) ? std::optional{streaming->twitchTrack} : std::nullopt;
-	streaming->StartEnhancedBroadcastingStream(vod_track_mixer);
+	try {
+		streaming->StartEnhancedBroadcastingStream(vod_track_mixer);
+	} catch (const std::exception &error) {
+		PRETTY_ERROR_RETURN(ErrorCode::Error, error.what());
+	} catch (...) {
+		PRETTY_ERROR_RETURN(ErrorCode::Error, "Failed to start enhanced broadcasting stream.");
+	}
 
 	rval.push_back(ipc::value((uint64_t)ErrorCode::Ok));
 	AUTO_DEBUG;

obs-studio-server/source/osn-enhanced-broadcasting-simple-streaming.cpp

@@ -23,6 +23,7 @@
 #include "shared.hpp"
 #include "nodeobs_audio_encoders.h"
 #include "osn-audio-track.hpp"
+#include <exception>
 #include <osn-video.hpp>
 
 void osn::IEnhancedBroadcastingSimpleStreaming::Register(ipc::server &srv)
@@ -115,7 +116,13 @@ void osn::IEnhancedBroadcastingSimpleStreaming::Start(void *data, const int64_t
 	}
 
 	// Note: unlike advanced mode, there is no Twitch VOD track for simple mode
-	streaming->StartEnhancedBroadcastingStream();
+	try {
+		streaming->StartEnhancedBroadcastingStream();
+	} catch (const std::exception &error) {
+		PRETTY_ERROR_RETURN(ErrorCode::Error, error.what());
+	} catch (...) {
+		PRETTY_ERROR_RETURN(ErrorCode::Error, "Failed to start enhanced broadcasting stream.");
+	}
 
 	rval.push_back(ipc::value((uint64_t)ErrorCode::Ok));
 	AUTO_DEBUG;

tests/osn-tests/src/test_osn_enhanced_broadcasting_advanced_streaming.ts

@@ -71,6 +71,55 @@ describe(testName, () => {
     // TODO: more tests:
     // - vertical primary canvas
 
+    it('Enhanced Broadcasting Advanced Streaming rejects without crashing in CI', function() {
+        // This test is CI only because CI is expected to hit a Twitch Enhanced Broadcasting rejection.
+        if (obs.isDarwin()) {
+            this.skip();
+        }
+
+        if (!obs.isCI()) {
+            this.skip();
+        }
+
+        const stream = osn.EnhancedBroadcastingAdvancedStreamingFactory.create();
+        let startError: Error = null;
+
+        try {
+            expect(stream).to.not.be.null;
+            stream.service = osn.ServiceFactory.legacySettings;
+            stream.service.update({
+                service: 'Twitch',
+                server: 'auto',
+                key: obs.userStreamKey,
+            });
+            stream.delay = osn.DelayFactory.create();
+            stream.reconnect = osn.ReconnectFactory.create();
+            stream.network = osn.NetworkFactory.create();
+            stream.video = obs.defaultVideoContext;
+            const track1 = osn.AudioTrackFactory.create(160, 'track1');
+            osn.AudioTrackFactory.setAtIndex(track1, 1);
+
+            try {
+                stream.start();
+            } catch (error) {
+                startError = error as Error;
+            }
+
+            expect(startError).to.not.be.null;
+            expect(osn.ServiceFactory.types()).to.include('rtmp_common');
+        } finally {
+            if (!startError) {
+                try {
+                    stream.stop();
+                } catch (error) {
+                    // Best-effort cleanup if the stream unexpectedly started.
+                }
+            }
+
+            osn.EnhancedBroadcastingAdvancedStreamingFactory.destroy(stream);
+        }
+    });
+
     it('Enhanced Broadcasting Advanced Streaming Single Canvas', async function() {
         if (obs.isDarwin()) {
             this.skip();