Use new video render context API in Display#1660
Open
aleksandr-voitenko wants to merge 3 commits intostagingfrom
Open
Use new video render context API in Display#1660aleksandr-voitenko wants to merge 3 commits intostagingfrom
aleksandr-voitenko wants to merge 3 commits intostagingfrom
Conversation
summeroff
approved these changes
Apr 6, 2026
sandboxcoder
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates display rendering in
obs-studio-nodeto use the new mix-based video render context introduced inobs-studio.Instead of setting only the current canvas before preview rendering,
DisplayCallback()now:(canvas, rendering mode)This replaces the old canvas-only setup:
obs_set_video_rendering_canvas(dp->m_canvas)obs_set_video_render_context(obs_video_mix_get(...))The callback also no longer applies
obs_set_video_rendering_mode()only for transition sources. Since the render mode is now set up front for the entire display callback, the old transition-only branch is no longer needed.Motivation and Context
This aligns
obs-studio-nodepreview/display rendering with the updatedobs-studiorender-context model.How Has This Been Tested?
Manually. Windows only.
Types of changes