[WIP] obs-browser: GPU-process-loss resilience + OnAcceleratedPaint teardown guard#739
Open
summeroff wants to merge 4 commits into
Open
[WIP] obs-browser: GPU-process-loss resilience + OnAcceleratedPaint teardown guard#739summeroff wants to merge 4 commits into
summeroff wants to merge 4 commits into
Conversation
Bump plugins/obs-browser to 5b30996 to pull in the OnAcceleratedPaint teardown-race guard (streamlabs/obs-browser#54), which fixes the libcef crash on BrowserManagerThread seen in dual-output sessions with browser sources. Branched from 31.1.2sl19. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bump plugins/obs-browser 5b30996 -> 9d18953 to add --disable-gpu-process-crash-limit (streamlabs/obs-browser#54), so a transient GPU reset (TDR) no longer escalates to Chromium's fatal 'GPU process isn't usable' abort. Combines with the OnAcceleratedPaint teardown guard already in this bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
summeroff
changed the title
Bump plugins/obs-browser 9d18953 -> 4002dac, the squash-merge of streamlabs/obs-browser#54 on streamlabs (GPU-process crash-limit flag + OnAcceleratedPaint teardown guard). Replaces the pre-merge PR-branch pointer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
summeroff
changed the title
* libobs-winrt: Guard WGC capture against removed graphics device (#733) * Guard DirectShow filter activation (#740) * libobs: append message/get_messages to obs_source_info (#735) * libobs: bound volmeter plane index against MAX_AV_PLANES (#737) * libobs: mix scene-item audio when item canvas is unset (#738) * libobs: Fix use-after-free of canvas view in audio thread (#736) * Add structured module load failures (#741) * Fix NDI 6 runtime loading on macOS --------- Co-authored-by: Vladimir <summeroff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
plugins/obs-browserto the merged streamlabs/obs-browser#54, which hardens hardware-accelerated browser sources against the libcef crash spike on Streamlabs Desktop 1.21.x. Branched from31.1.2sl19.Change
Submodule gitlink only, no other files. The merged commit contains:
--disable-gpu-process-crash-limit(primary) — survive transient GPU-process loss instead of escalating to Chromium's fatalIntentionallyCrashBrowserForUnusableGpuProcess()("GPU process isn't usable. Goodbye.").OnAcceleratedPaint(secondary hardening) — close a teardown TOCTOU window.Root cause
Both Sentry-reported crashes share
gpu_data_manager_impl_private.cc:454: GPU process isn't usable. Goodbye.— Chromium deliberately aborting after CEF's GPU process dies past its crash limit, correlated with a host D3D11 device removal / TDR (887A0005, "Rebuilding all assets", shared-texture rebuild failures). The crash-limit flag is the primary mitigation; theOnAcceleratedPaintguard is secondary. Full analysis and verification status in streamlabs/obs-browser#54.Verification
streamlabs.4002dac).Status
obs-browser#54 is merged; this PR now points at its squash commit
4002daconstreamlabs(no longer the pre-merge PR-branch pointer). Ready to merge.