Skip to content

Commit 33d2d25

Browse files
authored
Remove code that print exceptions directly (#154)
1 parent cafde3b commit 33d2d25

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

mesh-worker-service/src/main/java/io/functionmesh/compute/rest/api/SinksImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ public void registerSink(
171171
namespace,
172172
sinkConfig,
173173
e);
174-
e.printStackTrace();
175174
throw new RestException(Response.Status.INTERNAL_SERVER_ERROR, e.getMessage());
176175
}
177176
}

mesh-worker-service/src/main/java/io/functionmesh/compute/rest/api/SourcesImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ public void registerSource(final String tenant,
160160
executeCall(call, V1alpha1Source.class);
161161
} catch (Exception e) {
162162
log.error("register {}/{}/{} source failed, error message: {}", tenant, namespace, sourceConfig, e);
163-
e.printStackTrace();
164163
throw new RestException(Response.Status.INTERNAL_SERVER_ERROR, e.getMessage());
165164
}
166165
}

mesh-worker-service/src/main/java/io/functionmesh/compute/util/FunctionsUtil.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import io.functionmesh.compute.functions.models.V1alpha1FunctionSpecPython;
3434
import io.functionmesh.compute.models.CustomRuntimeOptions;
3535
import io.kubernetes.client.custom.Quantity;
36+
import lombok.extern.slf4j.Slf4j;
3637
import org.apache.commons.lang3.StringUtils;
3738
import org.apache.logging.log4j.util.Strings;
3839
import org.apache.pulsar.common.functions.ConsumerConfig;
@@ -50,6 +51,7 @@
5051
import java.util.HashMap;
5152
import java.util.Map;
5253

54+
@Slf4j
5355
public class FunctionsUtil {
5456
public final static String cpuKey = "cpu";
5557
public final static String memoryKey = "memory";
@@ -93,7 +95,7 @@ public static V1alpha1Function createV1alpha1FunctionFromFunctionConfig(String k
9395
try {
9496
functionDetails = FunctionConfigUtils.convert(functionConfig, null);
9597
} catch (IllegalArgumentException ex) {
96-
ex.printStackTrace();
98+
log.error("cannot convert FunctionConfig to FunctionDetails", ex);
9799
throw new RestException(Response.Status.BAD_REQUEST, "functionConfig cannot be parsed into functionDetails");
98100
}
99101

mesh-worker-service/src/main/java/io/functionmesh/compute/util/SinksUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public static V1alpha1Sink createV1alpha1SkinFromSinkConfig(String kind, String
137137
try {
138138
functionDetails = SinkConfigUtils.convert(sinkConfig, extractedSinkDetails);
139139
} catch (Exception ex) {
140-
ex.printStackTrace();
140+
log.error("cannot convert SinkConfig to FunctionDetails", ex);
141141
throw new RestException(Response.Status.BAD_REQUEST, "functionConfig cannot be parsed into functionDetails");
142142
}
143143

mesh-worker-service/src/main/java/io/functionmesh/compute/util/SourcesUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public static V1alpha1Source createV1alpha1SourceFromSourceConfig(String kind, S
129129
try {
130130
functionDetails = SourceConfigUtils.convert(sourceConfig, extractedSourceDetails);
131131
} catch (IllegalArgumentException ex) {
132-
ex.printStackTrace();
132+
log.error("cannot convert SourceConfig to FunctionDetails", ex);
133133
throw new RestException(Response.Status.BAD_REQUEST, "functionConfig cannot be parsed into functionDetails");
134134
}
135135

mesh-worker-service/src/main/java/io/functionmesh/compute/worker/MeshConnectorsManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public static TreeMap<String, FunctionMeshConnectorDefinition> searchForConnecto
6161
results.put(d.getName(), d);
6262
}
6363
} catch (IOException e) {
64-
e.printStackTrace();
64+
log.error("Cannot parse connector definitions", e);
6565
}
6666

6767
return results;

0 commit comments

Comments
 (0)