Skip to content

Commit 9395e12

Browse files
authored
Fixed override jar and location value (#166)
* Avoid override jar and location value
1 parent eeed042 commit 9395e12

3 files changed

Lines changed: 20 additions & 4 deletions

File tree

mesh-worker-service/src/main/java/io/functionmesh/compute/rest/api/FunctionsImpl.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,12 @@ private void upsertFunction(final String tenant,
311311
v1alpha1Function.getSpec().setVolumeMounts(volumeMountsList);
312312
}
313313
if (functionsWorkerServiceCustomConfigs.get("extraDependenciesDir") != null) {
314-
V1alpha1FunctionSpecJava v1alpha1FunctionSpecJava = new V1alpha1FunctionSpecJava();
314+
V1alpha1FunctionSpecJava v1alpha1FunctionSpecJava;
315+
if (v1alpha1Function.getSpec() != null && v1alpha1Function.getSpec().getJava() != null) {
316+
v1alpha1FunctionSpecJava = v1alpha1Function.getSpec().getJava();
317+
} else {
318+
v1alpha1FunctionSpecJava = new V1alpha1FunctionSpecJava();
319+
}
315320
v1alpha1FunctionSpecJava.setExtraDependenciesDir(
316321
(String)functionsWorkerServiceCustomConfigs.get("extraDependenciesDir"));
317322
v1alpha1Function.getSpec().setJava(v1alpha1FunctionSpecJava);

mesh-worker-service/src/main/java/io/functionmesh/compute/rest/api/SinksImpl.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,8 +346,14 @@ private void upsertSink(final String tenant,
346346
.getWorkerConfig().getFunctionsWorkerServiceCustomConfigs();
347347
Object volumes = functionsWorkerServiceCustomConfigs.get("volumes");
348348
if (functionsWorkerServiceCustomConfigs.get("extraDependenciesDir") != null) {
349-
V1alpha1SinkSpecJava v1alpha1SinkSpecJava = new V1alpha1SinkSpecJava();
350-
v1alpha1SinkSpecJava.setExtraDependenciesDir((String)functionsWorkerServiceCustomConfigs.get("extraDependenciesDir"));
349+
V1alpha1SinkSpecJava v1alpha1SinkSpecJava;
350+
if (v1alpha1Sink.getSpec() != null && v1alpha1Sink.getSpec().getJava() != null) {
351+
v1alpha1SinkSpecJava = v1alpha1Sink.getSpec().getJava();
352+
} else {
353+
v1alpha1SinkSpecJava = new V1alpha1SinkSpecJava();
354+
}
355+
v1alpha1SinkSpecJava.setExtraDependenciesDir(
356+
(String)functionsWorkerServiceCustomConfigs.get("extraDependenciesDir"));
351357
v1alpha1Sink.getSpec().setJava(v1alpha1SinkSpecJava);
352358
}
353359
if (volumes != null) {

mesh-worker-service/src/main/java/io/functionmesh/compute/rest/api/SourcesImpl.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,12 @@ private void upsertSource(final String tenant,
320320
v1alpha1Source.getSpec().getPod().setVolumes(volumesList);
321321
}
322322
if (functionsWorkerServiceCustomConfigs.get("extraDependenciesDir") != null) {
323-
V1alpha1SourceSpecJava v1alpha1SourceSpecJava = new V1alpha1SourceSpecJava();
323+
V1alpha1SourceSpecJava v1alpha1SourceSpecJava;
324+
if (v1alpha1Source.getSpec() != null && v1alpha1Source.getSpec().getJava() != null) {
325+
v1alpha1SourceSpecJava = v1alpha1Source.getSpec().getJava();
326+
} else {
327+
v1alpha1SourceSpecJava = new V1alpha1SourceSpecJava();
328+
}
324329
v1alpha1SourceSpecJava.setExtraDependenciesDir(
325330
(String)functionsWorkerServiceCustomConfigs.get("extraDependenciesDir"));
326331
v1alpha1Source.getSpec().setJava(v1alpha1SourceSpecJava);

0 commit comments

Comments
 (0)