Fix MQTTProxyProtocolMethodProcessor processPingReq not respond bug#1814
Merged
Technoboy- merged 1 commit intoOct 17, 2025
Merged
Conversation
oneby-wang
requested review from
Technoboy-,
coderzc and
mattisonchao
as code owners
|
@oneby-wang:Thanks for your contribution. For this PR, do we need to update docs? |
coderzc
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a mqtt client connects mop without sending any message or subscribing any topic, the mqtt client will get keep-alive timeout error due to Proxy not send any pingResp to the client.
Modifications
Send a pingResp even when topicBrokers is empty.
Verifying this change
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)