fix(apiserver-resources): ignore not-found errors during deletion (#386)

* fix(rolebinding): ignore not-found error during deletion

When deleting a RoleBinding, if the resource doesn't exist on the cloud
API server, treat it as success instead of retrying indefinitely. This
prevents the controller from getting stuck in an error loop during
helm uninstall when the remote resource was already cleaned up.

* test(controllers): cover not-found deletion for apiserver resources

Agent-Logs-Url: https://github.com/streamnative/pulsar-resources-operator/sessions/b16d9baf-494b-4238-a360-615646daac66

Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>

* fix(controllers): unify delete-time not-found handling

Agent-Logs-Url: https://github.com/streamnative/pulsar-resources-operator/sessions/ee155778-92d2-4761-a44d-8ea1051096ed

Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>

---------

Co-authored-by: Rui Fu <freeznet@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>

Author: 3 people

controllers/apikey_controller.go

@@ -213,13 +213,11 @@ func (r *APIKeyReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	if !apiKey.DeletionTimestamp.IsZero() {
 		if controllerutil.ContainsFinalizer(apiKey, APIKeyFinalizer) {
 			if err := apiKeyClient.DeleteAPIKey(ctx, apiKey); err != nil {
-				if !apierrors.IsNotFound(err) {
+				if !ignoreDeleteNotFound(logger, err, "Remote APIKey already deleted or not found", "apiKey", apiKey.Name) {
 					r.updateAPIKeyStatus(ctx, apiKey, err, "DeleteFailed",
 						fmt.Sprintf("Failed to delete external resources: %v", err))
 					return ctrl.Result{}, err
 				}
-				logger.Info("Remote APIKey already deleted or not found",
-					"apiKey", apiKey.Name)
 			}
 			controllerutil.RemoveFinalizer(apiKey, APIKeyFinalizer)
 			if err := r.Update(ctx, apiKey); err != nil {