feat: support TLS authentication and customized volumes#184
Merged
Conversation
tomjo
force-pushed
the
feature/tlsauthhelm
branch
2 times, most recently
from
ba7416a to
6e37f6e
Compare
tomjo
force-pushed
the
feature/tlsauthhelm
branch
from
6e37f6e to
0e9833c
Compare
# Conflicts: # charts/pulsar-resources-operator/Chart.yaml # charts/pulsar-resources-operator/tests/deployment_test.yaml # charts/pulsar-resources-operator/values.yaml
Member
|
@freeznet Please review |
freeznet
reviewed
Apr 11, 2025
Member
freeznet
left a comment
freeznet
left a comment
There was a problem hiding this comment.
overall the changes lgtm, but please revert the changes to version part, thanks.
Member
|
@freeznet PTAL |
freeznet
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #108
Motivation
Helm chart changes related to #143 Adds the updated CRD and adds support for volumes to the operator to provide the necessary certificates (e.g. from a secret). I bumped the version to v0.5.0 because that is the milestone tag used on #143.
Modifications
Verifying this change
This change added tests and can be verified as follows:
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)