feat: add configurable max-concurrent-reconciles flag#387
Merged
Conversation
When deleting a RoleBinding, if the resource doesn't exist on the cloud API server, treat it as success instead of retrying indefinitely. This prevents the controller from getting stuck in an error loop during helm uninstall when the remote resource was already cleaned up.
Add --max-concurrent-reconciles CLI flag (default 1) to control the number of concurrent reconciles per controller. This is exposed via Helm values as features.maxConcurrentReconciles. Applied to PulsarConnection and RoleBinding controllers. Customers with many RoleBindings (e.g. 85+) can increase this to speed up reconciliation significantly.
Contributor
|
@mattisonchao:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
the
doc-info-missing
freeznet
previously approved these changes
Mar 28, 2026
Only pass --max-concurrent-reconciles when the value is greater than 1, so the chart remains compatible with older operator images that don't support this flag.
freeznet
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--max-concurrent-reconcilesCLI flag (default1) to control concurrent reconciles per controllerfeatures.maxConcurrentReconcilesPulsarConnectionReconcilerandRoleBindingReconcilerMotivation
Customers with many RoleBindings (85+ in this case) experience slow reconciliation due to sequential processing. With concurrency=5, 85 RoleBindings reconcile in ~90s vs ~180s with concurrency=1.
Test plan