fix(rbac): Add aggregation labels to the clusterrole#416
Open
ulrichgiraud wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ulrich GIRAUD <ulrich.giraud@altirnao.com>
Contributor
|
@ulrichgiraud:Thanks for your contribution. For this PR, do we need to update docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
Motivation
The ClusterRole shipped by this chart does not carry any RBAC aggregation labels, so users or service accounts bound to the standard Kubernetes admin / edit ClusterRoles cannot manage the operator's CRDs (PulsarTenant, PulsarNamespace, PulsarTopic, ...) out of the box. Every consumer has to either add extra ClusterRoleBindings or patch the chart via post-rendering to inject the labels.
Modifications
Added the standard RBAC aggregation labels to the manager ClusterRole template:
This is the minimal change discussed in the linked issue. The optional companion read-only ClusterRole (aggregate-to-view) and the values.yaml toggles are intentionally left out of this PR, happy to follow up with a second PR based on maintainer feedback.
Verifying this change
This change added tests and can be verified as follows:
helm unittest
Documentation
This change only affects the rendered RBAC manifests. It does not introduce new APIs, configuration values, or user-facing behaviour that would require documentation updates.