Skip to content

Fix flaky tests #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Technoboy- merged 1 commit into from
Apr 24, 2026
Merged

Fix flaky tests #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions pkg/ctl/namespace/clusters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,25 @@ func TestClusters(t *testing.T) {
assert.True(t, strings.Contains(getOut.String(), "test-replication-cluster"))

// reset namespace clusters for other test case
updateTenantArgs = []string{"update", "--allowed-clusters", "standalone", "public"}
_, execErr, _, err = tenant.TestTenantCommands(tenant.UpdateTenantCmd, updateTenantArgs)
assert.Nil(t, err)
assert.Nil(t, execErr)

setArgs = []string{"set-clusters", "public/test-cluster-namespace", "--clusters", "standalone"}
setOut, execErr, _, _ = TestNamespaceCommands(setReplicationClusters, setArgs)
assert.Nil(t, execErr)
assert.Equal(t, setOut.String(), "Set replication clusters successfully for public/test-cluster-namespace\n")

updateTenantArgs = []string{"update", "--allowed-clusters", "standalone", "public"}
_, execErr, _, err = tenant.TestTenantCommands(tenant.UpdateTenantCmd, updateTenantArgs)
assert.Nil(t, err)
assert.Nil(t, execErr)
}

func TestFailureCluster(t *testing.T) {
setArgs := []string{"set-clusters", "public/test-cluster-namespace", "--clusters", "invalid-cluster"}
_, execErr, _, _ := TestNamespaceCommands(setReplicationClusters, setArgs)
args := []string{"create", "public/test-cluster-namespace-failure"}
_, execErr, _, err := TestNamespaceCommands(createNs, args)
assert.Nil(t, err)
assert.Nil(t, execErr)

setArgs := []string{"set-clusters", "public/test-cluster-namespace-failure", "--clusters", "invalid-cluster"}
_, execErr, _, _ = TestNamespaceCommands(setReplicationClusters, setArgs)
assert.NotNil(t, execErr)
assert.Equal(t, execErr.Error(), "code: 403 reason: Invalid cluster id: invalid-cluster")
}
5 changes: 5 additions & 0 deletions pkg/ctl/namespace/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ func TestCreateNsForCluster(t *testing.T) {
assert.Equal(t, "test-cluster", police.ReplicationClusters[0])

// reset namespace clusters for other test case
resetNsArgs := []string{"set-clusters", "public/test-namespace-cluster", "--clusters", "standalone"}
_, execErr, _, err = TestNamespaceCommands(setReplicationClusters, resetNsArgs)
assert.Nil(t, err)
assert.Nil(t, execErr)

updateTenantArgs = []string{"update", "--allowed-clusters", "standalone", "public"}
_, execErr, _, err = tenant.TestTenantCommands(tenant.UpdateTenantCmd, updateTenantArgs)
assert.Nil(t, err)
Expand Down
Loading