fix: address PR review comments

Author: freeznet

docs/tools/pulsar_admin_functions.md

@@ -1,6 +1,6 @@
 #### pulsar_admin_functions
 
-**Claude connector safety:** Actual MCP tools: `pulsar_admin_functions_read` (`list`, `get`, `status`, `stats`, `querystate`) and `pulsar_admin_functions_write` (`create`, `update`, `delete`, `download`, `start`, `stop`, `restart`, `putstate`, `trigger`, `upload`).
+**Claude connector safety:** Actual MCP tools: `pulsar_admin_functions_read` (`list`, `get`, `status`, `stats`, `querystate`, `download`) and `pulsar_admin_functions_write` (`create`, `update`, `delete`, `start`, `stop`, `restart`, `putstate`, `trigger`, `upload`).
 
 
 Manage Apache Pulsar Functions for stream processing. Pulsar Functions are lightweight compute processes that can consume messages from one or more Pulsar topics, apply user-defined processing logic, and produce results to another topic. Functions support Java, Python, and Go runtimes, enabling complex event processing, data transformations, filtering, and integration with external systems.

pkg/mcp/static_tool_annotations_test.go

@@ -25,37 +25,21 @@ import (
 func TestStreamNativeStaticToolAnnotations(t *testing.T) {
 	tools := []struct {
 		name        string
+		tool        mcpgotypes.Tool
 		readOnly    bool
 		destructive bool
 	}{
-		{name: "sncloud_logs", readOnly: true},
-		{name: "sncloud_resources_apply", destructive: true},
-		{name: "sncloud_resources_delete", destructive: true},
-	}
-
-	definitions := map[string]struct {
-		readOnly    bool
-		destructive bool
-	}{
-		"sncloud_logs":             {readOnly: true},
-		"sncloud_resources_apply":  {destructive: true},
-		"sncloud_resources_delete": {destructive: true},
-	}
-
-	constructed := map[string]mcpgotypes.Tool{
-		"sncloud_logs":             NewSNCloudLogsTool(),
-		"sncloud_resources_apply":  NewSNCloudResourcesApplyTool(),
-		"sncloud_resources_delete": NewSNCloudResourcesDeleteTool(),
+		{name: "sncloud_logs", tool: NewSNCloudLogsTool(), readOnly: true},
+		{name: "sncloud_resources_apply", tool: NewSNCloudResourcesApplyTool(), destructive: true},
+		{name: "sncloud_resources_delete", tool: NewSNCloudResourcesDeleteTool(), destructive: true},
 	}
 
 	for _, tt := range tools {
-		tool := constructed[tt.name]
-		expected := definitions[tt.name]
-		require.NotEmpty(t, tool.Annotations.Title, tt.name)
-		require.NotNil(t, tool.Annotations.ReadOnlyHint, tt.name)
-		require.NotNil(t, tool.Annotations.DestructiveHint, tt.name)
-		require.Equal(t, expected.readOnly, *tool.Annotations.ReadOnlyHint, tt.name)
-		require.Equal(t, expected.destructive, *tool.Annotations.DestructiveHint, tt.name)
+		require.NotEmpty(t, tt.tool.Annotations.Title, tt.name)
+		require.NotNil(t, tt.tool.Annotations.ReadOnlyHint, tt.name)
+		require.NotNil(t, tt.tool.Annotations.DestructiveHint, tt.name)
+		require.Equal(t, tt.readOnly, *tt.tool.Annotations.ReadOnlyHint, tt.name)
+		require.Equal(t, tt.destructive, *tt.tool.Annotations.DestructiveHint, tt.name)
 	}
 }
 

pkg/mcp/toolannotations/annotations.go

@@ -12,20 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Copyright 2025 StreamNative
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
 // Package toolannotations provides helpers for setting MCP tool safety annotations.
 package toolannotations