streamnative_service_account doesn't re-create deleted service account

[erniebilling]

streamnative_service_account should be able to re-recreate a service account if someone accidentally deletes it.

Demo terraform:

terraform {
  required_providers {
    streamnative = {
      source  = "streamnative/streamnative"
      version = "0.4.2"
    }
  }
}

provider "streamnative" {
}

variable "organization_name" {
    type = string
    description = "The name of the organization"
}

variable account_name {
    type = string
    description = "The name of the account to creaate"
    default = "test-account"
}

resource "streamnative_service_account" "service_account" {
  name         = var.account_name
  organization = var.organization_name
  admin        = false
}

Steps:

1. plan and apply given terraform
2. use stream native console to delete service account "test-account"
3. plan given terraform

Gets error

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: ERROR_READ_SERVICE_ACCOUNT: serviceaccounts.cloud.streamnative.io "test-account" not found
│ 
│   with streamnative_service_account.service_account,
│   on main.tf line 24, in resource "streamnative_service_account" "service_account":
│   24: resource "streamnative_service_account" "service_account" {

Should detect missing service account and re-create it.

[erniebilling]

Same result with provider streamnative/streamnative 0.6.0

[erniebilling]

Doesn’t seem to be fixed with latest provider 0.6.0On Nov 5, 2024, at 19:29, Eric Shen ***@***.***> wrote: this is fixed by #67 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[ericsyh]

@erniebilling yeap, I double checked and this is a separate case and was not covered by PR 67. Will take a look how to support this case.

[freeznet]

It seems the Read logic is directly throw the error when resources are missing. We could add recreation trigger logic to Read when resources been removed by external. I will working on this issue and create a PR for it.