Skip to content

Commit 23a15e1

Browse files
committed
Use minikube setup script for TS Playwright tests
Signed-off-by: Michael Edgar <medgar@redhat.com>
1 parent 2861c87 commit 23a15e1

3 files changed

Lines changed: 58 additions & 15 deletions

File tree

.github/workflows/integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,5 +231,5 @@ jobs:
231231
Playwright:
232232
if: ${{ contains(github.event.pull_request.labels.*.name, 'safe to test') || github.repository == 'streamshub/console' }}
233233
uses: ./.github/workflows/playwright-tests.yml
234-
needs:
235-
- build-images
234+
#needs:
235+
# - build-images

.github/workflows/playwright-tests.yml

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,33 @@ jobs:
1515
- name: Checkout
1616
uses: actions/checkout@v6
1717

18-
- name: Download Images
19-
uses: actions/download-artifact@v8
18+
- name: Set Up JDK
19+
uses: actions/setup-java@v5
2020
with:
21-
name: streamshub-images
21+
java-version: '21'
22+
distribution: 'temurin'
23+
24+
- name: Cache Maven Packages
25+
uses: actions/cache@v6
26+
with:
27+
path: ~/.m2/repository
28+
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
29+
restore-keys: |
30+
${{ runner.os }}-maven-
31+
32+
- name: Fetch Operator Framework Utilities
33+
run: ./operator/bin/fetch-operator-utilities.sh
2234

2335
- name: Setup Minikube Environment
24-
uses: ./.github/actions/setup-minikube
25-
with:
26-
MEM: 8g
27-
CPUS: 2
36+
run: |
37+
# Needed for skopeo in setup-minikube.sh script
38+
sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
39+
40+
# Needed to copy locally built images to minikube registry
41+
sudo apt-get install -y socat
42+
43+
# Execute the setup
44+
MINIKUBE_CPU_COUNT=2 MINIKUBE_MEMORY=8g MINIKUBE_DRIVER=docker ./systemtests/scripts/setup-minikube.sh
2845
2946
- name: Set Dynamic Environment Vars
3047
run: |

systemtests/scripts/setup-minikube.sh

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ trap 'handle_error $LINENO' ERR
1717
OLM_VERSION="v0.42.0"
1818
OLM_SCRIPT_SHA256="1e8065cb503d2ee94ce82dd2591618022852f53a43df908b9f8c7d314cff3532"
1919

20-
if [ -n "${MINIKUBE_PROFILE}" ] ; then
20+
if [ -n "${MINIKUBE_PROFILE:-}" ] ; then
2121
MK_PROFILE_ARG="--profile=${MINIKUBE_PROFILE}"
2222
else
2323
MK_PROFILE_ARG=""
2424
fi
2525

26-
if ! minikube status ${MK_PROFILE_ARG} ; then
26+
if ! minikube status ${MK_PROFILE_ARG} >/dev/null 2>&1 ; then
2727
minikube start ${MK_PROFILE_ARG} \
2828
--driver=${MINIKUBE_DRIVER:-kvm2} \
2929
--cpus=${MINIKUBE_CPU_COUNT:-6} \
@@ -56,9 +56,34 @@ rm -v ${OLM_INSTALL_SCRIPT}
5656

5757
# Build and push Console images ---------------------------------
5858
PROJECT_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout | tr '[:upper:]' '[:lower:]')
59-
CONTAINER_RUNTIME=$(which podman || which docker)
60-
SKOPEO_LOCAL=$(which podman >/dev/null && echo "containers-storage:" || echo "docker-daemon:")
61-
PLATFORMS=$(docker system info --format '{{.OSType}}/{{.Architecture}}' 2>/dev/null || podman info --format={{".Version.OsArch"}})
59+
60+
if which podman 1>/dev/null 2>&1 && which docker 1>/dev/null 2>&1 ; then
61+
if docker --version | grep "podman" ; then
62+
# podman masquerading as docker
63+
CONTAINER_RUNTIME=podman
64+
else
65+
# both present, prefer docker
66+
CONTAINER_RUNTIME=docker
67+
fi
68+
elif which podman 1>/dev/null 2>&1 ; then
69+
CONTAINER_RUNTIME=podman
70+
else
71+
CONTAINER_RUNTIME=docker
72+
fi
73+
74+
if [ "${CONTAINER_RUNTIME}" == "podman" ] ; then
75+
SKOPEO_LOCAL="containers-storage:"
76+
else
77+
SKOPEO_LOCAL="docker-daemon:"
78+
fi
79+
80+
if [ -z "${PLATFORMS:-}" ] ; then
81+
if [ "${CONTAINER_RUNTIME}" == "podman" ] ; then
82+
PLATFORMS=$(podman info --format={{".Version.OsArch"}})
83+
else
84+
PLATFORMS=$(docker system info --format '{{.OSType}}/{{.Architecture}}' 2>/dev/null)
85+
fi
86+
fi
6287

6388
mvn clean package -Pcontainer-image -B --no-transfer-progress -DskipTests \
6489
-Dquarkus.kubernetes.namespace='$${NAMESPACE}' \
@@ -73,7 +98,8 @@ mvn clean package -Pcontainer-image -B --no-transfer-progress -DskipTests \
7398

7499
${CONTAINER_RUNTIME} build \
75100
-t localhost:5000/streamshub/console-operator-bundle:${PROJECT_VERSION} \
76-
-f operator/target/bundle/streamshub-console-operator/bundle.Dockerfile
101+
-f operator/target/bundle/streamshub-console-operator/bundle.Dockerfile \
102+
operator/target/bundle/streamshub-console-operator
77103

78104
./operator/bin/generate-catalog.sh ./operator/target/bundle/streamshub-console-operator true
79105

0 commit comments

Comments
 (0)