Skip to content

Commit 2ccf4a5

Browse files
committed
Remove commented code, create topics async
Signed-off-by: Michael Edgar <medgar@redhat.com>
1 parent e70892b commit 2ccf4a5

2 files changed

Lines changed: 2 additions & 13 deletions

File tree

systemtests/src/main/java/com/github/streamshub/systemtests/utils/resourceutils/kafka/KafkaTopicUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
public class KafkaTopicUtils {
2323
private static final Logger LOGGER = LogWrapper.getLogger(KafkaTopicUtils.class);
24-
24+
2525
private KafkaTopicUtils() {}
2626

2727
/**
@@ -57,7 +57,7 @@ public static List<KafkaTopic> setupTopicsIfNeededAndReturn(String namespace, St
5757
KubeResourceManager.get().deleteResourceWithWait(existingTopics.toArray(new KafkaTopic[0]));
5858
}
5959

60-
KubeResourceManager.get().createResourceWithWait(topics.toArray(new KafkaTopic[0]));
60+
KubeResourceManager.get().createResourceAsyncWait(topics.toArray(new KafkaTopic[0]));
6161

6262
return topics;
6363
}

systemtests/src/main/java/com/github/streamshub/systemtests/utils/testchecks/TopicChecks.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,13 @@ public static void checkOverviewPageTopicState(TestCaseConfig tcc, String kafkaN
4040
PwUtils.navigate(tcc, PwPageUrls.getOverviewPage(tcc, kafkaName));
4141

4242
// Status
43-
// PwUtils.waitForContainsText(tcc, ClusterOverviewPageSelectors.COPS_TOPICS_CARD_TOTAL_TOPICS, total + " topics", true);
44-
// PwUtils.waitForContainsText(tcc, ClusterOverviewPageSelectors.COPS_TOPICS_CARD_TOTAL_PARTITIONS, partitions + " partitions", true);
4543
PlaywrightAssertions
4644
.assertThat(tcc.page().locator(ClusterOverviewPageSelectors.COPS_TOPICS_CARD_TOTAL_TOPICS))
4745
.containsText(total + " topics");
4846
PlaywrightAssertions
4947
.assertThat(tcc.page().locator(ClusterOverviewPageSelectors.COPS_TOPICS_CARD_TOTAL_PARTITIONS))
5048
.containsText(partitions + " partitions");
5149

52-
// PwUtils.waitForContainsText(tcc, ClusterOverviewPageSelectors.COPS_TOPICS_CARD_FULLY_REPLICATED, fullyReplicated + " Fully replicated", true);
53-
// PwUtils.waitForContainsText(tcc, ClusterOverviewPageSelectors.COPS_TOPICS_CARD_UNDER_REPLICATED, underReplicated + " Under replicated", true);
54-
// PwUtils.waitForContainsText(tcc, ClusterOverviewPageSelectors.COPS_TOPICS_CARD_UNAVAILABLE, unavailable + " Unavailable", true);
5550
PlaywrightAssertions
5651
.assertThat(tcc.page().locator(ClusterOverviewPageSelectors.COPS_TOPICS_CARD_FULLY_REPLICATED))
5752
.containsText(fullyReplicated + " Fully replicated");
@@ -79,15 +74,11 @@ public static void checkTopicsPageTopicState(TestCaseConfig tcc, String kafkaNam
7974
LOGGER.info("Verify Overview Page topic status [{} total topics] [FullyReplicated: {}] [UnderReplicated: {}] [Unavailabe: {}]", total, fullyReplicated, underReplicated, unavailable);
8075
// Total topic count
8176
PwUtils.navigate(tcc, PwPageUrls.getTopicsPage(tcc, kafkaName));
82-
// PwUtils.waitForContainsText(tcc, TopicsPageSelectors.TPS_HEADER_TOTAL_TOPICS_BADGE, total + " total", true);
8377
PlaywrightAssertions
8478
.assertThat(tcc.page().locator(TopicsPageSelectors.TPS_HEADER_TOTAL_TOPICS_BADGE))
8579
.containsText(total + " total");
8680

8781
// Status
88-
// PwUtils.waitForContainsText(tcc, TopicsPageSelectors.TPS_HEADER_BADGE_STATUS_SUCCESS, Integer.toString(fullyReplicated), true);
89-
// PwUtils.waitForContainsText(tcc, TopicsPageSelectors.TPS_HEADER_BADGE_STATUS_WARNING, Integer.toString(underReplicated), true);
90-
// PwUtils.waitForContainsText(tcc, TopicsPageSelectors.TPS_HEADER_BADGE_STATUS_ERROR, Integer.toString(unavailable), true);
9182
PlaywrightAssertions
9283
.assertThat(tcc.page().locator(TopicsPageSelectors.TPS_HEADER_BADGE_STATUS_SUCCESS))
9384
.containsText(Integer.toString(fullyReplicated));
@@ -175,8 +166,6 @@ public static void checkPaginationPage(TestCaseConfig tcc, int topicsCount, List
175166
private static void checkPaginationContent(TestCaseConfig tcc, int pageNum, int numOfFinalPage, int topicsOnPage, int lowBoundary, int highBoundary, int topicsCount, String paginationTextSelector, String moveButtonSelector) {
176167
LOGGER.debug("Checking page {}/{}", pageNum, numOfFinalPage);
177168
// Check that correct number of topics is displayed
178-
// PwUtils.waitForLocatorVisible(tcc, new CssBuilder(TopicsPageSelectors.TPS_TABLE_ROWS).nth(1).build());
179-
// assertEquals(topicsOnPage, tcc.page().locator(TopicsPageSelectors.TPS_TABLE_ROWS).all().size());
180169
PlaywrightAssertions
181170
.assertThat(tcc.page().locator(new CssBuilder(TopicsPageSelectors.TPS_TABLE_ROWS)
182171
.withDesc()

0 commit comments

Comments
 (0)