Add common script to setup minikube for Playwright and system tests#2696
Conversation
MikeEdgar
force-pushed
the
minikube-init
branch
8 times, most recently
from
feaaaff to
23a15e1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/systemtests run |
🏃 System tests run started️ 🏃Build phase succeeded. Triggering systemtests. Used parameters
|
tomncooper
left a comment
tomncooper
left a comment
There was a problem hiding this comment.
I think this is a good move. It would be good to continue this trend with the running of the system/playwrite tests so they could be run locally or in CI with a single command.
I ran the script locally on my Fedora 44 box with Minikube 1.38.1 and it completed successfully. I had a couple of suggested improvements.
My main question is why you didn't use minikube image load ?
MikeEdgar
force-pushed
the
minikube-init
branch
2 times, most recently
from
33bb1e5 to
16a56e6
Compare
tomncooper
left a comment
tomncooper
left a comment
There was a problem hiding this comment.
LGTM, just a couple of nits/suggestions.
My only thought was do you need to also delete the old .github/actions/setup-minikube/action.yml?
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com> Co-authored-by: Thomas Cooper <code@tomcooper.dev>
|
@tomncooper your latest suggestions are applied in the final commit. I'll merge the PR once the CI passes. |
|
4 participants
Add common script to setup minikube for Playwright and system tests in support of #2682.
In addition to adding the script, this PR modifies the
playwright-testsandsystemtestsworkflows to use it. Note, thatsystemtestswill continue to use the version onmainprior to this PR being merged. Once merged, future PRs will execute thesystemtestsworkflow from the PR instead of frommain. The Pre-Systemtests workflow will continue to execute frommain, which is intended for security.🚧⚠️ This is known to only work on Linux at the moment.
Run minikube setup
Run test(s)
CONSOLE_CLUSTER_DOMAIN="$(minikube ip).nip.io" mvn -pl systemtests verify -DskipSTs=false -Dit.test=MessagesSTAll commands above are from the project root.