Skip to content

Commit e44a3f6

Browse files
Jeroen Schutrupfhussonnois
authored andcommitted
fix(core): in health endpoint, filter enabled extension providers
The /health endpoint is throwing internal server errors e.g. when only having the jikkou and kafka providers enabled: ``` Health indicator [iceberg] reported exception: io.jikkou.core.extension.exceptions.NoSuchExtensionException: No extension registered for type 'interface io.jikkou.core.health.HealthIndicator', and qualifier '@nAmed(iceberg) and @enabled(true)' ``` This is caused by the findAllDescriptorsByClass() call not filtering for enabled extensions. This commit implemenents a trivial fix to do such filtering.
1 parent 9922a54 commit e44a3f6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

core/src/main/java/io/jikkou/core/DefaultApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ public ApiGroupList listApiGroups() {
262262
@Override
263263
public ApiHealthIndicatorList getApiHealthIndicators() {
264264
List<ApiHealthIndicator> indicators = extensionFactory
265-
.findAllDescriptorsByClass(HealthIndicator.class)
265+
.findAllDescriptorsByClass(HealthIndicator.class, Qualifiers.enabled())
266266
.stream()
267267
.map(descriptor -> new ApiHealthIndicator(descriptor.name(), descriptor.description()))
268268
.toList();

0 commit comments

Comments
 (0)