fix(provider/kafka): replace block() with toFuture().get() in listConsumerGroups#767
Open
jeroen92 wants to merge 1 commit into
Open
Conversation
…sumerGroups Calling Reactor's block() from a Netty event loop thread throws IllegalStateException when Kafka is slow to respond, because Reactor's fast-path (which skips the non-blocking thread check) is only taken when the Mono is already resolved. Under normal conditions the Kafka futures resolve quickly enough to hit that fast-path, making the failure intermittent and correlated with broker latency or availability. Replace block() with toFuture().get() to bypass Reactor's non-blocking thread detection. Also explicitly handle ExecutionException and InterruptException. In the former we now unwrap the exception cause so the user-facing error message will be more useful. When catching the InterruptException we re-set the thread's interrupt flag, to prevent having stuck threads during shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When fetching Kafka Consumer Groups from the Jikkou API, we often get 500's returned, e.g.
Calling Reactor's block() from a Netty event loop thread throws IllegalStateException when Kafka is slow to respond, because Reactor's fast-path (which skips the non-blocking thread check) is only taken when the Mono is already resolved. Under normal conditions the Kafka futures resolve quickly enough to hit that fast-path, making the failure intermittent and correlated with broker latency or availability.
Replace block() with toFuture().get() to bypass Reactor's non-blocking thread detection.
Also explicitly handle ExecutionException and InterruptException. In the former we now unwrap the exception cause so the user-facing error message will be more useful. When catching the InterruptException we re-set the thread's interrupt flag, to prevent having stuck threads during shutdown.