fix(cli): tolerate empty Jikkou config file#769
Merged
Conversation
Treat an empty or whitespace-only ~/.jikkou/config file as if it did not exist, falling back to the default context instead of crashing with "Couldn't read configuration file". Malformed JSON still surfaces as an error.
|
Contributor
Security Scan ResultsVulnerabilities detected: Scanned by Trivy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.jikkou/configexists but is empty (or whitespace-only). It now falls back to the default context instead of crashing withCouldn't read configuration file.ConfigurationContext.isExists()so every existing fallback branch handles the empty-file case the same way it handles the missing-file case. No changes to callers.Test plan
ConfigurationContextTestcovers: empty file, whitespace-only file, and malformed JSON (regression guard)./mvnw -pl cli -Dtest=ConfigurationContextTest test— 3/3 passing