Skip to content

Commit aa7a601

Browse files
committed
_codegen: use strings.Builder
1 parent 841f024 commit aa7a601

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

_codegen/main.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ func (f *testFunc) Qualifier(p *types.Package) string {
228228
func (f *testFunc) Params() string {
229229
sig := f.TypeInfo.Type().(*types.Signature)
230230
params := sig.Params()
231-
p := ""
231+
var p strings.Builder
232232
comma := ""
233233
to := params.Len()
234234
var i int
@@ -238,20 +238,23 @@ func (f *testFunc) Params() string {
238238
}
239239
for i = 1; i < to; i++ {
240240
param := params.At(i)
241-
p += fmt.Sprintf("%s%s %s", comma, param.Name(), types.TypeString(param.Type(), f.Qualifier))
241+
p.WriteString(comma)
242+
p.WriteString(param.Name())
243+
p.WriteString(" ")
244+
p.WriteString(types.TypeString(param.Type(), f.Qualifier))
242245
comma = ", "
243246
}
244247
if sig.Variadic() {
245248
param := params.At(params.Len() - 1)
246-
p += fmt.Sprintf("%s%s ...%s", comma, param.Name(), types.TypeString(param.Type().(*types.Slice).Elem(), f.Qualifier))
249+
fmt.Fprintf(&p, "%s%s ...%s", comma, param.Name(), types.TypeString(param.Type().(*types.Slice).Elem(), f.Qualifier))
247250
}
248-
return p
251+
return p.String()
249252
}
250253

251254
func (f *testFunc) ForwardedParams() string {
252255
sig := f.TypeInfo.Type().(*types.Signature)
253256
params := sig.Params()
254-
p := ""
257+
var p strings.Builder
255258
comma := ""
256259
to := params.Len()
257260
var i int
@@ -261,14 +264,15 @@ func (f *testFunc) ForwardedParams() string {
261264
}
262265
for i = 1; i < to; i++ {
263266
param := params.At(i)
264-
p += fmt.Sprintf("%s%s", comma, param.Name())
267+
p.WriteString(comma)
268+
p.WriteString(param.Name())
265269
comma = ", "
266270
}
267271
if sig.Variadic() {
268272
param := params.At(params.Len() - 1)
269-
p += fmt.Sprintf("%s%s...", comma, param.Name())
273+
fmt.Fprintf(&p, "%s%s...", comma, param.Name())
270274
}
271-
return p
275+
return p.String()
272276
}
273277

274278
func (f *testFunc) ParamsFormat() string {

0 commit comments

Comments
 (0)