Skip to content

CI: run tests separately from build jobs#1796

Open
dolmen wants to merge 1 commit into
stretchr:masterfrom
dolmen-go:ci-run-tests-separately-from-build-tasks
Open

CI: run tests separately from build jobs#1796
dolmen wants to merge 1 commit into
stretchr:masterfrom
dolmen-go:ci-run-tests-separately-from-build-tasks

Conversation

@dolmen
Copy link
Copy Markdown
Collaborator

@dolmen dolmen commented Sep 16, 2025

Summary

Reorganize GitHub Actions workflows to run tests the same way on all Go versions, and so remove running tests from the 'build' jobs (which run job only on 'oldstable' and 'stable').

Changes

  • Refactor .github/workflows/main.yml
  • Add comments on build matrices to explain how the order of Go versions is defined

Motivation

This makes the build matrix of the 'test' job more consistent.

Copy link
Copy Markdown
Collaborator

@brackendawson brackendawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build: job need only run for stable now.

I'm not 100% happy with it being called "Build" but I can't think of a better name.

@dolmen dolmen force-pushed the ci-run-tests-separately-from-build-tasks branch from df38021 to 85bf767 Compare May 12, 2026 05:20
@dolmen
Copy link
Copy Markdown
Collaborator Author

dolmen commented May 12, 2026

I think that the 'build' tasks must always be runnable with both stable and oldstable. This is important after a new Go release, when not every contributor has switched to the new one.

So I prefer to keep oldstable.

@dolmen dolmen requested a review from brackendawson May 12, 2026 05:22
@dolmen dolmen added the github_actions Pull requests that update GitHub Actions code label May 12, 2026
@dolmen dolmen requested a review from ccoVeille May 12, 2026 05:22
@dolmen dolmen added the internal/cleanup Internal change to ease maintenance without external impact label May 12, 2026
Comment thread .github/workflows/main.yml
ccoVeille
ccoVeille previously approved these changes May 13, 2026
Reorganize GitHub Actions workflows to run tests the same way on all Go
versions, and so remove running tests from the 'build' jobs (which run
job only on 'oldstable' and 'stable').

This makes the build matrix of the 'test' job more consistent.

Add comments explaining the logic of each build matrix.
@dolmen dolmen force-pushed the ci-run-tests-separately-from-build-tasks branch from 85bf767 to 89db34b Compare May 14, 2026 07:52
@dolmen dolmen requested review from alexandear and ccoVeille May 14, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code internal/cleanup Internal change to ease maintenance without external impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants