mock: add OnF method#1814
Open
burik666 wants to merge 3 commits into
Open
Conversation
Author
|
bump. |
dolmen
added
pkg-mock
Collaborator
|
I like the implementation, but I don't like the method name. |
dolmen
requested changes
May 12, 2026
| // Mock. | ||
| // On("MyMethod", 1).Return(nil). | ||
| // On("MyOtherMethod", 'a', 'b', 'c').Return(errors.New("Some Error")) | ||
| // |
Collaborator
There was a problem hiding this comment.
Add link to OnF with a godoc link to make the new method more discoverable (especially by agents).
Author
There was a problem hiding this comment.
Added a short godoc cross-reference to OnF from On to improve discoverability.
Author
Renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds method
OnFtomock.Mockandmock.Callto allow defining mock expectations using function references instead of string method names.Changes
OnFmethod tomock.Mockandmock.Call.runtime.FuncForPC).On.Motivation
Currently, mock expectations are defined using string literals for method names, which can be error-prone and break easily during refactoring.
OnF allows developers to use actual function references, improving type safety and maintainability.
Related issues