_codegen: modernize#1890
Merged
Merged
Conversation
dolmen
added
internal/codegen
dolmen
force-pushed
the
dolmen/codegen-modernize
branch
from
aa7a601 to
0389302
Compare
ccoVeille
approved these changes
May 13, 2026
Modernize the code generator for the go/types era: - enable go/parser.SkipObjectResolution for reduced resource usage - replace use of deprecated functions which use object resolution
dolmen
force-pushed
the
dolmen/codegen-modernize
branch
from
c67c068 to
098f8d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize the code generator: remove use of deprecated APIs, use strings.Builder.
Changes
parser.SkipObjectResolutionfor lighter resource usage, and drop use of deprecated APIs (ast.NewPackage) that rely on object resolution. Seego/ast.Object.Motivation
Use modern APIs of the go/types era (go 1.18+).
Related issues