test: assert zero GPU validation errors after each game test

Author: xen2

sources/engine/Stride.Graphics.Regression/GameTestBase.cs

@@ -611,7 +611,38 @@ protected static void RunGameTest(GameTestBase game)
 
             game.ScreenShotAutomationEnabled = !ForceInteractiveMode;
 
-            GameTester.RunGameTest(game);
+            // Track GPU validation errors and warnings during the test
+            var gpuValidationErrors = new List<string>();
+            var gpuValidationWarnings = new List<string>();
+            void OnGlobalMessage(ILogMessage msg)
+            {
+                if (msg.Module != nameof(GraphicsDevice))
+                    return;
+                if (msg.Type == LogMessageType.Error)
+                    gpuValidationErrors.Add(msg.Text);
+                else if (msg.Type == LogMessageType.Warning && !IsKnownHarmlessWarning(msg.Text))
+                    gpuValidationWarnings.Add(msg.Text);
+            }
+            GlobalLogger.GlobalMessageLogged += OnGlobalMessage;
+
+            try
+            {
+                GameTester.RunGameTest(game);
+            }
+            finally
+            {
+                GlobalLogger.GlobalMessageLogged -= OnGlobalMessage;
+            }
+
+            // Assert no GPU validation errors
+            if (gpuValidationErrors.Count > 0)
+                Assert.Fail($"GPU validation reported {gpuValidationErrors.Count} error(s):" + Environment.NewLine
+                    + string.Join(Environment.NewLine, gpuValidationErrors));
+
+            // Assert no GPU validation warnings
+            if (gpuValidationWarnings.Count > 0)
+                Assert.Fail($"GPU validation reported {gpuValidationWarnings.Count} warning(s):" + Environment.NewLine
+                    + string.Join(Environment.NewLine, gpuValidationWarnings));
 
             // If there were comparison failures, assert them now
             if (game.ScreenShotAutomationEnabled)
@@ -637,6 +668,21 @@ void AssertMissingComparisonImages()
             }
         }
 
+        /// <summary>
+        ///   Filters out known harmless D3D11 debug layer warnings that cannot be avoided
+        ///   without significant refactoring.
+        /// </summary>
+        private static bool IsKnownHarmlessWarning(string text)
+        {
+            return false
+                // || text.Contains("still bound on input")       // D3D11: RT set while SRV still bound (auto-unbinds)
+                // || text.Contains("Forcing PS shader resource") // D3D11: consequence of the above
+                || text.Contains("SetPrivateData")                // D3D11: debug name size mismatch on reuse
+                || text.Contains("NULL Sampler maps to default")  // D3D11: unbound sampler uses default state
+                || text.Contains("Live ")                         // D3D11/D3D12: ReportLiveObjects at shutdown
+                || text.Contains("SetPrivateData");               // D3D11: debug name size mismatch on reuse
+        }
+
         /// <summary>
         ///   Searches for the root folder of the Stride solution by traversing upward from the test's binary directory.
         /// </summary>

sources/engine/Stride.Graphics/Direct3D11/CommandList.Direct3D11.cs

@@ -373,7 +373,7 @@ internal void SetSamplerState(ShaderStage stage, int slot, SamplerState samplerS
             {
                 samplerStates[slotIndex] = samplerState;
 
-                var nativeSampler = samplerState is not null ? samplerState.NativeSamplerState : default;
+                var nativeSampler = (samplerState ?? GraphicsDevice.SamplerStates.LinearClamp).NativeSamplerState;
 
                 switch (stage)
                 {

sources/engine/Stride.Graphics/Direct3D11/GraphicsDevice.Direct3D11.cs

@@ -23,7 +23,7 @@ namespace Stride.Graphics
 {
     public unsafe partial class GraphicsDevice
     {
-        private static readonly Logger Log = GlobalLogger.GetLogger("GraphicsDevice");
+        private static readonly Logger Log = GlobalLogger.GetLogger(nameof(GraphicsDevice));
 
         internal readonly int ConstantBufferDataPlacementAlignment = 16;
 

sources/engine/Stride.Graphics/Direct3D12/GraphicsDevice.Direct3D12.cs

@@ -22,7 +22,7 @@ namespace Stride.Graphics
 {
     public unsafe partial class GraphicsDevice
     {
-        private static readonly Logger Log = GlobalLogger.GetLogger("GraphicsDevice");
+        private static readonly Logger Log = GlobalLogger.GetLogger(nameof(GraphicsDevice));
 
         internal readonly int ConstantBufferDataPlacementAlignment = D3D12.ConstantBufferDataPlacementAlignment;
 

sources/engine/Stride.Graphics/OpenGL/GraphicsDevice.OpenGL.cs

@@ -32,7 +32,7 @@ public partial class GraphicsDevice
     {
         internal readonly int ConstantBufferDataPlacementAlignment = 16;
 
-        private static readonly Logger Log = GlobalLogger.GetLogger("GraphicsDevice");
+        private static readonly Logger Log = GlobalLogger.GetLogger(nameof(GraphicsDevice));
 
         internal int FrameCounter;
 

sources/engine/Stride.Graphics/Vulkan/GraphicsAdapterFactory.Vulkan.cs

@@ -98,8 +98,7 @@ internal class GraphicsAdapterFactoryInstance : IDisposable
         internal bool HasXlibSurfaceSupport;
         internal bool HasSurfaceSupport;
 
-        // We use GraphicsDevice (similar to OpenGL)
-        private static readonly Logger Log = GlobalLogger.GetLogger("GraphicsDevice");
+        private static readonly Logger Log = GlobalLogger.GetLogger(nameof(GraphicsDevice));
 
         public unsafe GraphicsAdapterFactoryInstance(bool enableValidation)
         {