Skip to content

chore: Update Silk.Net from 2.22.0 to 2.23.0#3126

Open
w0wca7a wants to merge 5 commits intostride3d:masterfrom
w0wca7a:updates/AssimpUpdate
Open

chore: Update Silk.Net from 2.22.0 to 2.23.0#3126
w0wca7a wants to merge 5 commits intostride3d:masterfrom
w0wca7a:updates/AssimpUpdate

Conversation

@w0wca7a
Copy link
Copy Markdown

@w0wca7a w0wca7a commented Apr 8, 2026

PR Details

Fixes bone twisting artifacts on animations.

This change adapts the fix described in Silk.NET PR #2489 and applies the same approach within Stride's animation system.
Full Silk.NET changelog in v2.23.0

Related Issue

#3116

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Copy Markdown
Collaborator

Eideren commented Apr 8, 2026

Note that afair silk.net packages must be updated in lockstep; other silk packages should be updated to match this new version

@VaclavElias
Copy link
Copy Markdown
Contributor

These if not more in Directory.Packages.props?

image

@w0wca7a
Copy link
Copy Markdown
Author

w0wca7a commented Apr 8, 2026

I'm not sure about other packages since I didn't check them. I need time to understand how stable they work.

@w0wca7a w0wca7a marked this pull request as draft April 8, 2026 09:48
@Kryptos-FR
Copy link
Copy Markdown
Member

Note that afair silk.net packages must be updated in lockstep; other silk packages should be updated to match this new version

Would it make sense to introduce a property (e.g. SilkVersion) and reuse it in all related packages? That way one line change would be necessary and it clearly conveys that they should be updated together.

I'm doing something similar for the AvaloniaVersion in the xplat-editor branch.

@w0wca7a
Copy link
Copy Markdown
Author

w0wca7a commented Apr 8, 2026

Would it make sense to introduce a property (e.g. SilkVersion) and reuse it in all related packages? That way one line change would be necessary and it clearly conveys that they should be updated together.

Overall, isn’t bad idea. But if a user ever needs to update/downgrade just one library, for example, Silk.Net.Assimp, since Silk.Net is a huge collection of separate packages covering rendering, input, import, VR, etc.?

@xen2 xen2 force-pushed the master branch 2 times, most recently from ab329f3 to 482bd28 Compare April 16, 2026 07:56
@w0wca7a w0wca7a changed the title chore: Update Silk.Net.Assimp from 2.22.0 to 2.23.0 chore: Update Silk.Net from 2.22.0 to 2.23.0 Apr 20, 2026
@w0wca7a
Copy link
Copy Markdown
Author

w0wca7a commented Apr 20, 2026

I had enough time to test Stride with the updated Silk.NET libraries. I haven't found any issues with them. Therefore, the PR is open for review.

@w0wca7a w0wca7a marked this pull request as ready for review April 20, 2026 13:22
w0wca7a added 3 commits April 20, 2026 16:28
* Add global property for all all Silk.NET dependencies
* Remove conflict with Stride.SharpFont
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants