Fix recent project version picker#3208
Closed
marko1olo wants to merge 1 commit into
Closed
Conversation
Member
|
@marko1olo Could you sign the Contributor License Agreement (CLA) please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenWithCommandWhy
The recent-project menu renders entries such as
Open with {version}, but the button did not pass the clicked version toRecentProjectViewModel.OpenWithCommand. The command therefore receivednulland fell back to the project's recorded version instead of the selected menu item.Part of #2744.
Tests
C:\hades\.dotnet-10.0.300\dotnet.exe test sources\launcher\Stride.Launcher.Tests\Stride.Launcher.Tests.csproj -v minimalC:\hades\.dotnet-10.0.300\dotnet.exe format sources\launcher\Stride.Launcher.Tests\Stride.Launcher.Tests.csproj whitespace --verify-no-changes --no-restore --include sources\launcher\Stride.Launcher.Tests\MainViewXamlTests.cs -v minimalgit -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --check