set up ESLint

Author: mockdeep

.circleci/config.yml

@@ -29,9 +29,8 @@ jobs:
           install-chrome: false
           install-chromedriver: false
 
-      # - node/install:
-      #     node-version: 16.13.1
-      #     install-yarn: true
+      - node/install:
+          node-version: lts
 
       - run:
           name: Which bundler?
@@ -55,19 +54,8 @@ jobs:
           paths:
             - vendor/bundle
 
-      # - restore_cache:
-      #     keys:
-      #       - yarn-{{ checksum "yarn.lock" }}
-      #       - yarn-
-
-      # - run:
-      #     name: Yarn Install
-      #     command: yarn install --cache-folder ~/.cache/yarn
-
-      # - save_cache:
-      #     key: yarn-{{ checksum "yarn.lock" }}
-      #     paths:
-      #       - ~/.cache/yarn
+      - node/install-packages:
+          pkg-manager: pnpm
 
       - run:
           name: Wait for DB
@@ -81,9 +69,9 @@ jobs:
       #     name: Brakeman
       #     command: bundle exec brakeman
 
-      # - run:
-      #     name: Stylelint
-      #     command: yarn stylelint
+      - run:
+          name: ESLint
+          command: pnpm lint
 
       - run:
           name: Rubocop

.gitignore

@@ -29,3 +29,5 @@ spec/examples.txt
 # Ignore local .env files
 *.local
 .env
+
+/node_modules

app/assets/javascripts/application.js

@@ -7,7 +7,7 @@
 //= require backbone-min.js
 
 _.templateSettings = {
-  interpolate: /\{\{\=(.+?)\}\}/g,
+  interpolate: /\{\{=(.+?)\}\}/g,
   evaluate: /\{\{(.+?)\}\}/g
 };
 

eslint.config.mjs

@@ -0,0 +1,45 @@
+import js from "@eslint/js";
+import globals from "globals";
+
+export default [
+  js.configs.recommended,
+  {
+    languageOptions: {
+      sourceType: "script",
+      globals: {
+        ...globals.browser,
+        Backbone: "readonly",
+        _: "readonly",
+        $: "readonly",
+        jQuery: "readonly",
+        Mousetrap: "readonly",
+      },
+    },
+    rules: {
+      "no-var": "off",
+      "no-unused-vars": "warn",
+    },
+  },
+  {
+    files: ["spec/javascript/spec/**"],
+    languageOptions: {
+      globals: {
+        describe: "readonly",
+        it: "readonly",
+        before: "readonly",
+        beforeEach: "readonly",
+        afterEach: "readonly",
+        sinon: "readonly",
+        chai: "readonly",
+        mocha: "readonly",
+        initMochaPhantomJS: "readonly",
+        Story: "readonly",
+        StoryView: "readonly",
+        StoryList: "readonly",
+      },
+    },
+  },
+  {
+    ignores: ["vendor/", "coverage/", "spec/javascript/support/", "public/"],
+  },
+];

package.json

@@ -0,0 +1,12 @@
+{
+  "private": true,
+  "scripts": {
+    "lint": "eslint app/assets/javascripts/ spec/javascript/spec/"
+  },
+  "devDependencies": {
+    "@eslint/js": "^9.21.0",
+    "eslint": "^9.21.0",
+    "globals": "^16.0.0"
+  },
+  "packageManager": "pnpm@10.4.1"
+}