Apply template update: Rubocop: add linter to disallow before blocks (#1486)

Source: mockdeep/Rails-Template#1399

Co-authored-by: Template Bot <template-bot@users.noreply.github.com>

Author: rails-template-sync[bot]

.rubocop.yml

@@ -1,9 +1,13 @@
+require:
+  - ./linters/rubocop/cop/rspec/no_before_hook
+
 inherit_from: .rubocop_todo.yml
 inherit_mode: { merge: [Exclude] }
 
 plugins:
   - rubocop-capybara
   - rubocop-factory_bot
+  - rubocop-i18n
   - rubocop-rails
   - rubocop-rake
   - rubocop-rspec
@@ -29,7 +33,11 @@ RSpec/MessageExpectation:
   EnforcedStyle: expect
   Exclude: [spec/support/matchers/**/*.rb]
 RSpec/MessageSpies: { EnforcedStyle: receive }
-RSpec/MultipleMemoizedHelpers: { Max: 0, AllowSubject: false }
+RSpec/MultipleMemoizedHelpers:
+  Max: 0
+  AllowSubject: false
+  Exclude:
+    - spec/linters/rubocop/**/*.rb
 Style/ClassAndModuleChildren: { EnforcedStyle: compact }
 Style/MethodCallWithArgsParentheses:
   AllowedMethods:
@@ -49,6 +57,13 @@ Style/WordArray: { EnforcedStyle: brackets }
 Style/DocumentationMethod: { Enabled: false }
 Style/Documentation: { Enabled: false }
 
+I18n/GetText/DecorateString:
+  Exclude:
+    - linters/**/*.rb
+I18n/RailsI18n/DecorateString:
+  Exclude:
+    - linters/**/*.rb
+
 ################################################################################
 #
 # Rules we don't want to enable

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 400`
-# on 2026-03-11 01:58:30 UTC using RuboCop version 1.85.1.
+# on 2026-04-07 03:24:43 UTC using RuboCop version 1.86.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,6 +12,31 @@ Capybara/NegationMatcherAfterVisit:
     - 'spec/system/account_setup_spec.rb'
     - 'spec/system/stories_index_spec.rb'
 
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+I18n/GetText/DecorateFunctionMessage:
+  Exclude:
+    - 'app/commands/cast_boolean.rb'
+    - 'app/models/user.rb'
+    - 'spec/support/matchers/change_all_records.rb'
+    - 'spec/support/matchers/change_record.rb'
+    - 'spec/support/matchers/invoke.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+I18n/GetText/DecorateString:
+  Exclude:
+    - 'Rakefile'
+    - 'spec/rails_helper.rb'
+    - 'spec/system/login_spec.rb'
+
+# Offense count: 4
+I18n/RailsI18n/DecorateString:
+  Exclude:
+    - 'Rakefile'
+    - 'spec/rails_helper.rb'
+    - 'spec/system/login_spec.rb'
+
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
@@ -188,6 +213,13 @@ RSpec/NestedGroups:
   Exclude:
     - 'spec/integration/feed_importing_spec.rb'
 
+# Offense count: 3
+RSpec/NoBeforeHook:
+  Exclude:
+    - 'spec/commands/feed/import_from_opml_spec.rb'
+    - 'spec/system/authentication_spec.rb'
+    - 'spec/system/profile_spec.rb'
+
 # Offense count: 5
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
@@ -260,6 +292,16 @@ Rails/Validation:
   Exclude:
     - 'app/models/story.rb'
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
+# SupportedStyles: nested, compact
+# SupportedStylesForClasses: ~, nested, compact
+# SupportedStylesForModules: ~, nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'linters/rubocop/cop/rspec/no_before_hook.rb'
+
 # Offense count: 23
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.

Gemfile

@@ -36,6 +36,7 @@ group :development do
   gem "rubocop", require: false
   gem "rubocop-capybara", require: false
   gem "rubocop-factory_bot", require: false
+  gem "rubocop-i18n", require: false
   gem "rubocop-rails", require: false
   gem "rubocop-rake", require: false
   gem "rubocop-rspec", require: false

Gemfile.lock

@@ -358,6 +358,9 @@ GEM
     rubocop-factory_bot (2.28.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
+    rubocop-i18n (3.2.3)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
     rubocop-rails (2.34.3)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
@@ -487,6 +490,7 @@ DEPENDENCIES
   rubocop
   rubocop-capybara
   rubocop-factory_bot
+  rubocop-i18n
   rubocop-rails
   rubocop-rake
   rubocop-rspec

linters/rubocop/cop/rspec/no_before_hook.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Disallows the use of `before` hooks in specs.
+      #
+      # @example
+      #   # bad
+      #   before { do_something }
+      #   before(:each) { do_something }
+      #
+      #   # good
+      #   # Inline setup directly in the example.
+      class NoBeforeHook < Base
+        MSG = "Do not use `before` hooks."
+
+        # @!method before_hook?(node)
+        def_node_matcher(:before_hook?, <<~PATTERN)
+          (block (send nil? :before ...) ...)
+        PATTERN
+
+        def on_block(node)
+          return unless before_hook?(node)
+
+          add_offense(node)
+        end
+
+        alias on_numblock on_block
+      end
+    end
+  end
+end

spec/linters/rubocop/cop/rspec/no_before_hook_spec.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require "rubocop"
+require "rubocop-rspec"
+require "rubocop/rspec/cop_helper"
+require "rubocop/rspec/expect_offense"
+require_relative("../../../../../linters/rubocop/cop/rspec/no_before_hook")
+
+RSpec.describe RuboCop::Cop::RSpec::NoBeforeHook do
+  include CopHelper
+  include RuboCop::RSpec::ExpectOffense
+
+  let(:cop) { described_class.new }
+
+  it "registers an offense for a before block" do
+    expect_offense(<<~RUBY)
+      before { do_something }
+      ^^^^^^^^^^^^^^^^^^^^^^^ RSpec/NoBeforeHook: Do not use `before` hooks.
+    RUBY
+  end
+
+  it "registers an offense for before(:each)" do
+    expect_offense(<<~RUBY)
+      before(:each) { do_something }
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RSpec/NoBeforeHook: Do not use `before` hooks.
+    RUBY
+  end
+
+  it "registers an offense for before(:all)" do
+    expect_offense(<<~RUBY)
+      before(:all) { do_something }
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RSpec/NoBeforeHook: Do not use `before` hooks.
+    RUBY
+  end
+
+  it "does not register an offense for an after block" do
+    expect_no_offenses(<<~RUBY)
+      after { do_something }
+    RUBY
+  end
+
+  it "does not register an offense for a regular method call" do
+    expect_no_offenses(<<~RUBY)
+      def setup
+        do_something
+      end
+    RUBY
+  end
+end