diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cd91918aa..8badbab31 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 400` -# on 2025-06-09 17:04:01 UTC using RuboCop version 1.76.0. +# on 2025-11-17 17:32:59 UTC using RuboCop version 1.81.7. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -33,7 +33,7 @@ Layout/MultilineMethodArgumentLineBreaks: - 'db/migrate/20240314031221_create_good_job_labels_index.rb' - 'db/migrate/20240314031223_create_index_good_job_jobs_for_candidate_lookup.rb' -# Offense count: 9 +# Offense count: 10 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredClasses. # AllowedMethods: ago, from_now, second, seconds, minute, minutes, hour, hours, day, days, week, weeks, fortnight, fortnights, in_milliseconds @@ -71,8 +71,9 @@ Metrics/PerceivedComplexity: - 'db/migrate/20240314031219_recreate_good_job_cron_indexes_with_conditional.rb' # Offense count: 3 -# Configuration parameters: Mode, AllowedMethods. +# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates. # AllowedMethods: call +# WaywardPredicates: nonzero? Naming/PredicateMethod: Exclude: - 'app/utils/sample_story.rb' @@ -109,7 +110,7 @@ RSpec/DescribeClass: Exclude: - 'spec/integration/feed_importing_spec.rb' -# Offense count: 34 +# Offense count: 35 # Configuration parameters: Max, CountAsOne. RSpec/ExampleLength: Exclude: @@ -130,6 +131,16 @@ RSpec/ExampleLength: - 'spec/utils/feed_discovery_spec.rb' - 'spec/utils/opml_parser_spec.rb' +# Offense count: 16 +RSpec/LeakyLocalVariable: + Exclude: + - 'spec/commands/feed/import_from_opml_spec.rb' + - 'spec/integration/feed_importing_spec.rb' + - 'spec/requests/feeds_controller_spec.rb' + - 'spec/requests/imports_controller_spec.rb' + - 'spec/requests/stories_controller_spec.rb' + - 'spec/utils/feed_discovery_spec.rb' + # Offense count: 17 # Configuration parameters: EnforcedStyle. # SupportedStyles: allow, expect @@ -169,27 +180,27 @@ RSpec/NestedGroups: Exclude: - 'spec/integration/feed_importing_spec.rb' -# Offense count: 26 +# Offense count: 5 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. RSpec/VerifiedDoubles: Exclude: - - 'spec/commands/feed/create_spec.rb' - 'spec/commands/feed/fetch_one_spec.rb' - 'spec/commands/feed/find_new_stories_spec.rb' - - 'spec/repositories/story_repository_spec.rb' - 'spec/tasks/remove_old_stories_spec.rb' - - 'spec/utils/feed_discovery_spec.rb' # Offense count: 2 -# Configuration parameters: IgnoreScopes, Include. -# Include: **/app/models/**/*.rb +Rails/Env: + Exclude: + - 'config/routes.rb' + - 'spec/rails_helper.rb' + +# Offense count: 2 +# Configuration parameters: IgnoreScopes. Rails/InverseOf: Exclude: - 'app/models/feed.rb' # Offense count: 3 -# Configuration parameters: Include. -# Include: db/**/*.rb Rails/ReversibleMigrationMethodDefinition: Exclude: - 'db/migrate/20130423001740_drop_email_from_user.rb' @@ -217,8 +228,6 @@ Rails/SkipsModelValidations: - 'db/migrate/20141102103617_fix_invalid_titles_with_unicode_line_endings.rb' # Offense count: 5 -# Configuration parameters: Include. -# Include: db/**/*.rb Rails/ThreeStateBooleanColumn: Exclude: - 'db/migrate/20130412185253_add_new_fields_to_stories.rb' @@ -240,8 +249,6 @@ Rails/TimeZone: # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Include. -# Include: **/app/models/**/*.rb Rails/Validation: Exclude: - 'app/models/story.rb' diff --git a/Gemfile.lock b/Gemfile.lock index 7c756c4fa..d6f46a851 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -95,7 +95,7 @@ GEM bcrypt (3.1.20) bigdecimal (3.3.1) bindex (0.8.1) - bootsnap (1.18.6) + bootsnap (1.19.0) msgpack (~> 1.2) builder (3.3.0) byebug (12.0.0) @@ -137,7 +137,7 @@ GEM railties (>= 6.1) drb (2.2.3) dumb_delegator (1.1.0) - erb (5.1.3) + erb (6.0.0) erubi (1.13.1) et-orbi (1.4.0) tzinfo @@ -286,7 +286,7 @@ GEM psych (>= 4.0.0) tsort regexp_parser (2.11.3) - reline (0.6.2) + reline (0.6.3) io-console (~> 0.5) rexml (3.4.4) rspec (3.13.2) @@ -327,10 +327,10 @@ GEM rubocop-capybara (2.22.1) lint_roller (~> 1.1) rubocop (~> 1.72, >= 1.72.1) - rubocop-factory_bot (2.27.1) + rubocop-factory_bot (2.28.0) lint_roller (~> 1.1) rubocop (~> 1.72, >= 1.72.1) - rubocop-rails (2.33.4) + rubocop-rails (2.34.0) activesupport (>= 4.2.0) lint_roller (~> 1.1) rack (>= 1.1) @@ -339,10 +339,10 @@ GEM rubocop-rake (0.7.1) lint_roller (~> 1.1) rubocop (>= 1.72.1) - rubocop-rspec (3.7.0) + rubocop-rspec (3.8.0) lint_roller (~> 1.1) - rubocop (~> 1.72, >= 1.72.1) - rubocop-rspec_rails (2.31.0) + rubocop (~> 1.81) + rubocop-rspec_rails (2.32.0) lint_roller (~> 1.1) rubocop (~> 1.72, >= 1.72.1) rubocop-rspec (~> 3.5) @@ -373,7 +373,7 @@ GEM actionpack (>= 6.1) activesupport (>= 6.1) sprockets (>= 3.0.0) - stringio (3.1.7) + stringio (3.1.8) stripe (17.2.0) sync (0.5.0) term-ansicolor (1.11.3) @@ -382,7 +382,7 @@ GEM thread (0.2.2) thread_safe (0.3.6) timeout (0.4.4) - tins (1.45.0) + tins (1.47.0) bigdecimal mize (~> 0.6) sync