fix opendota parsing

Author: stringhandler

meta/spec/matches/UC-014-parse-match.md

@@ -25,26 +25,50 @@ Feature: Parse Match
     Given a match is in the "Parsing" state
     When OpenDota finishes parsing the match
     Then the per-minute CS data is stored
-    Then the per-minute networth data for all 10 players is stored
+    Then the per-minute gold (gold_t) data for all 10 players is stored
     And item purchase timings are stored
     And lane role is detected and stored
     And the match parse_state changes to "Parsed"
-    And the UI updates to show the "Parsed" state
+    And the UI updates to show goal result chips for the match
 
-  Scenario: Match parsing fails
+  Scenario: Match parsing fails with pending status
     Given a match has been requested for parsing
-    When OpenDota returns an error or the match cannot be parsed
+    When OpenDota has not yet finished processing the match (lh_t/dn_t not available)
     Then the match parse_state changes to "Failed"
-    And the UI shows a "Failed" indicator
+    And the Goals cell shows a grey clock icon (🕐)
+    And hovering the icon shows "not yet parsed / will be picked up on next sync"
+
+  Scenario: Match parsing fails with an unexpected error
+    Given a match has been requested for parsing
+    When OpenDota returns a non-recoverable error (network failure, unexpected response)
+    Then the match parse_state changes to "Failed"
+    And the Goals cell shows a red warning icon (⚠)
+    And hovering the icon shows the specific error message
+
+  Scenario: Failed match shows Retry button
+    Given a match has parse_state = Failed
+    When the user views the match list
+    Then the Goals cell shows a "↺ Retry" button
+    And clicking it re-attempts the full parse flow
+
+  Scenario: Match visible as parsed on OpenDota but Unparsed locally
+    Given a match exists in the local database with parse_state = Unparsed
+    And the match IS fully parsed on OpenDota (lh_t, dn_t and gold_t data available)
+    When the user clicks "Parse" or auto-parse runs
+    Then the parse succeeds and the match transitions to parse_state = Parsed
+    And goal chips are shown in the Goals cell
 
   Scenario: Automatic retry polling
-    Given one or more matches have parse_state = Unparsed
-    Then the application polls every 30 seconds for recent unparsed matches
-    And automatically requests parsing for each unparsed match found
+    Given one or more matches have parse_state = Unparsed or Failed
+    Then the application polls every 30 seconds for recent unparsed/failed matches
+    And automatically requests parsing for each one found
 ```
 
 ## Notes
 - Parsing is automatic and does not require manual user action
 - The UI updates in real-time using a match-state-changed event
 - Parsed data enables per-minute charts and item timing goals
 - The poll interval is 30 seconds
+- Per-match parse errors are shown inline (icon + tooltip) — no global error banner
+- Per-minute gold data is stored from the OpenDota `gold_t` field (not `net_worth`, which is a scalar)
+- A grey clock indicates a transient/pending state; a red warning indicates an actual error

src-tauri/src/lib.rs

@@ -924,7 +924,7 @@ async fn parse_match(app: tauri::AppHandle, match_id: i64, steam_id: String) ->
 
         // Store per-minute networth for all players (used by PartnerNetworth goals)
         for p in &detailed_match.players {
-            if let Some(nw_t) = &p.net_worth {
+            if let Some(nw_t) = &p.gold_t {
                 let _ = insert_player_networth(&conn, match_id, p.player_slot, nw_t);
             }
         }
@@ -1145,7 +1145,7 @@ async fn backfill_historical_matches(
 
                 // Store per-minute networth for all players (used by PartnerNetworth goals)
                 for p in &detailed_match.players {
-                    if let Some(nw_t) = &p.net_worth {
+                    if let Some(nw_t) = &p.gold_t {
                         let _ = insert_player_networth(&conn, m.match_id, p.player_slot, nw_t);
                     }
                 }
@@ -1306,7 +1306,7 @@ async fn reparse_pending_matches(
 
                 // Store per-minute networth for all players (used by PartnerNetworth goals)
                 for p in &detailed_match.players {
-                    if let Some(nw_t) = &p.net_worth {
+                    if let Some(nw_t) = &p.gold_t {
                         let _ = insert_player_networth(&conn, m.match_id, p.player_slot, nw_t);
                     }
                 }

src-tauri/src/opendota.rs

@@ -86,7 +86,7 @@ pub struct DetailedPlayer {
     pub lane_role: Option<i32>,  // 1=carry, 2=mid, 3=offlane, 4=soft support, 5=hard support
     pub lh_t: Option<Vec<i32>>,  // Last hits at each minute
     pub dn_t: Option<Vec<i32>>,  // Denies at each minute
-    pub net_worth: Option<Vec<i32>>,  // Networth at each minute
+    pub gold_t: Option<Vec<i32>>,  // Gold (net worth) at each minute — OpenDota field name
     pub purchase_log: Option<Vec<PurchaseLogEntry>>,  // Item purchases
 }
 
@@ -306,7 +306,7 @@ pub async fn fetch_match_details(match_id: i64) -> Result<DetailedMatch, String>
     let match_details: DetailedMatch = response
         .json()
         .await
-        .map_err(|_| "This match hasn't been fully parsed by OpenDota yet. It will be picked up on the next sync.".to_string())?;
+        .map_err(|e| format!("Unexpected response from OpenDota for this match ({}). Try again or check https://www.opendota.com/matches/{}", e, match_id))?;
 
     Ok(match_details)
 }