fix(receipt): preserve success extra metadata#10
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra:keyword toMpp::Receipt.successReceiptWhy
Mpp::Receiptalready modelsextra, and receipt parsing/formatting preserves it in thePayment-Receiptheader. TheReceipt.successconvenience constructor dropped that metadata, which made it harder for successful payment receipts to carry trace IDs or other opaque settlement evidence without manually constructing the receipt.Verification
mise exec ruby@3.4 -- ruby -Ilib -Itest test/mpp/test_parsing.rb -n test_receipt_success_factory_preserves_extrapassed after the fixmise exec ruby@3.4 -- bundle exec ruby -Itest test/mpp/test_parsing.rb -n test_receipt_success_factory_preserves_extramise exec ruby@3.4 -- bundle exec ruby -Itest test/mpp/test_parsing.rbmise exec ruby@3.4 -- bundle exec rake testmise exec ruby@3.4 -- bundle exec standardrbmise exec ruby@3.4 -- bundle exec srb tc