fix(parsing): ignore quoted payment schemes#11
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WWW-Authenticatevalues by scanning auth schemes outside quoted stringsPayment realmBearerWhy
MPP clients may receive merged
WWW-Authenticateheaders with multiple auth schemes. The parser should only treatPaymentas an auth scheme at real scheme boundaries, not inside quoted challenge parameters. This keeps challenge selection stable for interop scenarios where proxies or servers merge authentication headers.Verification
mise exec ruby@3.3 -- ruby -c lib/mpp/challenge.rbmise exec ruby@3.3 -- ruby -c test/mpp/test_parsing.rbmise exec ruby@3.3 -- bundle exec ruby -Ilib -Itest test/mpp/test_parsing.rbmise exec ruby@3.3 -- bundle exec standardrb lib/mpp/challenge.rb test/mpp/test_parsing.rbmise exec ruby@3.3 -- bundle exec rake testgit diff --check