feat: add payment lifecycle hooks#15
Open
brendanjryan wants to merge 2 commits into
Open
Conversation
Contributor
raubrey-stripe
left a comment
raubrey-stripe
left a comment
There was a problem hiding this comment.
Couple q's but overall looking good!
Comment on lines
+138
to
+146
| if payment_response.code.to_i.between?(200, 299) && @events.has_handlers?(Mpp::Events::PAYMENT_RESPONSE) | ||
| @events.emit(Mpp::Events::PAYMENT_RESPONSE, { | ||
| challenge: challenge, | ||
| credential: auth_header, | ||
| input: url, | ||
| method: matched_method, | ||
| response: payment_response | ||
| }) | ||
| end |
Contributor
There was a problem hiding this comment.
Should we emit payment failed events when it's non-2xx?
| begin | ||
| event_credential = nil | ||
| if @events.has_handlers?(Mpp::Events::CHALLENGE_RECEIVED) | ||
| event_credential = @events.emit_first(Mpp::Events::CHALLENGE_RECEIVED, { |
Contributor
There was a problem hiding this comment.
Is it significant that this event is the only one to use emit_first?
raubrey-stripe
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add client and server payment lifecycle hooks for observing challenges, credentials, payment responses, successes, and failures.
This mirror similar functionality in other SDKs and documented at: tempoxyz/mpp#649