Skip to content

Remove billing details update restriction for cards added with Tap to Add#12947

Open
samer-stripe wants to merge 1 commit into
masterfrom
samer/remove-billing-details-restriction-for-tta-cards
Open

Remove billing details update restriction for cards added with Tap to Add#12947
samer-stripe wants to merge 1 commit into
masterfrom
samer/remove-billing-details-restriction-for-tta-cards

Conversation

@samer-stripe
Copy link
Copy Markdown
Collaborator

Summary

Remove billing details update restriction for cards added with Tap to Add, allowing customers to change details such as CVC and card brand choice without needing to input a ZIP code in automatic mode.

Motivation

Feedback from implementation review

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe force-pushed the samer/remove-billing-details-restriction-for-tta-cards branch from c6471c9 to 0cef51c Compare April 23, 2026 05:20
@github-actions
Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │             compressed             │          uncompressed          
          ├─────────────┬─────────────┬────────┼───────────┬───────────┬────────
 APK      │ old         │ new         │ diff   │ old       │ new       │ diff   
──────────┼─────────────┼─────────────┼────────┼───────────┼───────────┼────────
      dex │     4.5 MiB │     4.5 MiB │ +372 B │   9.7 MiB │   9.7 MiB │ +572 B 
     arsc │     3.6 MiB │     3.6 MiB │    0 B │   3.6 MiB │   3.6 MiB │    0 B 
 manifest │     5.8 KiB │     5.8 KiB │    0 B │  30.8 KiB │  30.8 KiB │    0 B 
      res │ 1,011.6 KiB │ 1,011.6 KiB │    0 B │   1.7 MiB │   1.7 MiB │    0 B 
   native │     2.7 MiB │     2.7 MiB │    0 B │   2.7 MiB │   2.7 MiB │    0 B 
    asset │      25 KiB │      25 KiB │  +10 B │  45.8 KiB │  45.8 KiB │  +10 B 
    other │   244.7 KiB │   244.7 KiB │  +21 B │ 503.6 KiB │ 503.6 KiB │    0 B 
──────────┼─────────────┼─────────────┼────────┼───────────┼───────────┼────────
    total │    12.1 MiB │    12.1 MiB │ +403 B │  18.2 MiB │  18.2 MiB │ +582 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 45111 │ 45115 │ +4 (+6 -2) 
   types │ 14215 │ 14215 │  0 (+0 -0) 
 classes │ 11548 │ 11548 │  0 (+0 -0) 
 methods │ 63195 │ 63196 │ +1 (+4 -3) 
  fields │ 40871 │ 40873 │ +2 (+2 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  319 │  319 │  0   
 entries │ 7429 │ 7429 │  0
APK
    compressed     │    uncompressed    │                                           
──────────┬────────┼───────────┬────────┤                                           
 size     │ diff   │ size      │ diff   │ path                                      
──────────┼────────┼───────────┼────────┼───────────────────────────────────────────
  4.5 MiB │ +372 B │   9.7 MiB │ +572 B │ ∆ classes.dex                             
 58.5 KiB │  +12 B │ 129.9 KiB │    0 B │ ∆ META-INF/CERT.SF                        
  8.9 KiB │  +10 B │   8.8 KiB │  +10 B │ ∆ assets/dexopt/baseline.prof             
 55.3 KiB │   +9 B │ 129.8 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │   +1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │   -1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                       
──────────┼────────┼───────────┼────────┼───────────────────────────────────────────
  4.7 MiB │ +403 B │   9.9 MiB │ +582 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   45111 │ 45115 │ +4 (+6 -2) 
  
  + , createdFromCardPresent=
  + , isAutomaticAddressInputMandatory=
  + ZZLL
  + generated_from
  + r8-map-id-39d0224a8b2fc81da1ec8cfe00707f41cb598097db9149af34976d1629353f91
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"39d0224a8b2fc81da1ec8cfe00707f41cb598097db9149af34976d1629353f91","r8-mode":"full","version":"8.13.19"}
  
  - r8-map-id-2c431255ecf1606d8be17761ec78631c32349ab1d6d4693bde12aeb7d220bd7a
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":23,"pg-map-id":"2c431255ecf1606d8be17761ec78631c32349ab1d6d4693bde12aeb7d220bd7a","r8-mode":"full","version":"8.13.19"}
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   63195 │ 63196 │ +1 (+4 -3) 
  
  + vh.a6 <init>(k, x5, String, Integer, Integer, String, String, String, z5, i, y5, String, w5, boolean)
  + xk.j a(boolean, a, String) → boolean
  + xk.j b(String, a) → boolean
  + xk.t <init>(a, boolean, boolean, boolean)
  
  - vh.a6 <init>(k, x5, String, Integer, Integer, String, String, String, z5, i, y5, String, w5)
  - xk.j a(String, a) → boolean
  - xk.t <init>(a, boolean, boolean)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40871 │ 40873 │ +2 (+2 -0) 
  
  + vh.a6 r: boolean
  + xk.t d: boolean

@samer-stripe samer-stripe force-pushed the samer/remove-billing-details-restriction-for-tta-cards branch from 0cef51c to d024be3 Compare April 23, 2026 06:14
@samer-stripe samer-stripe marked this pull request as ready for review April 23, 2026 14:44
@samer-stripe samer-stripe requested review from a team as code owners April 23, 2026 14:44
Copy link
Copy Markdown
Collaborator

@amk-stripe amk-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this restriction for all cards without a zip code? It's not clear to me why this would need to be a fix for only cards added via tap to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants