Add Google Pay display items support for line item breakdown.#13136
Open
jaynewstrom-stripe wants to merge 4 commits into
Open
Add Google Pay display items support for line item breakdown.#13136jaynewstrom-stripe wants to merge 4 commits into
jaynewstrom-stripe wants to merge 4 commits into
Conversation
Contributor
|
Diffuse output: APKDEX |
jaynewstrom-stripe
force-pushed
the
jaynewstrom/google-pay-display-items
branch
from
bb39b4a to
486abb1
Compare
jaynewstrom-stripe
force-pushed
the
jaynewstrom/google-pay-display-items
branch
from
486abb1 to
8b2a30c
Compare
Contributor
There was a problem hiding this comment.
Should we extract these detekt changes?
| return GooglePayJsonFactory.DisplayItem( | ||
| label = label, | ||
| type = GooglePayJsonFactory.DisplayItem.Type.LINE_ITEM, | ||
| price = unitAmount ?: total, |
Contributor
There was a problem hiding this comment.
Suggested change
| price = unitAmount ?: total, | |
| price = subtotal, |
from claude's suggestion.
Current:
Widget x2: $10.00 (unit amount)
Tax: $1.60
Total: $21.60 ← doesn't add up
Should this be subtotal instead? That way:
Widget x2: $20.00 (line subtotal)
Tax: $1.60
Total: $21.60 ← adds up
Contributor
There was a problem hiding this comment.
Also we should have tests for this.
Collaborator
Author
There was a problem hiding this comment.
The fix needs #13187
I was going to follow up with a more complete fix.
|
|
||
| checkoutSession.totalSummary?.let { summary -> | ||
| items += summary.discountAmounts.map { it.asDisplayItem() } | ||
| items += summary.taxAmounts.map { it.asDisplayItem() } |
Contributor
There was a problem hiding this comment.
For the TaxAmount that is already inclusive, this would double-counts the tax.
So if a line item costs $10.00 with 8% inclusive tax ($0.74 tax included in the $10.00):
Widget: $10.00 ← already includes tax
Tax: $0.74 ← adding this double-counts
---
Displayed: $10.74 but actual total is $10.00
Collaborator
Author
There was a problem hiding this comment.
Line items won't include tax after #13187
| args: GooglePayPaymentMethodLauncherContractV2.Args | ||
| ): GooglePayJsonFactory.TransactionInfo { | ||
| // Google Pay requires totalPriceLabel when displayItems are present. | ||
| val label = args.label ?: if (args.displayItems.isNotEmpty()) "Total" else null |
Contributor
There was a problem hiding this comment.
Do we need localized strings?
Comment on lines
+506
to
+510
| class DisplayItem( | ||
| val label: String, | ||
| val type: Type, | ||
| val price: Long, | ||
| ) : Parcelable { |
Contributor
There was a problem hiding this comment.
Do we need the status as well?
Collaborator
Author
There was a problem hiding this comment.
What is status? What would we need it for?
Contributor
There was a problem hiding this comment.
From goole pay documentation
The following variables define price variance:
FINAL
PENDING
Default to FINAL if not provided.
I only see this optional field on SHIPPING_OPTION in their example though.
Contributor
There was a problem hiding this comment.
Is SHIPPING_OPTION out of scope here?
Collaborator
Author
There was a problem hiding this comment.
For now, yes.
cttsai-stripe
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for displaying line items in the Google Pay payment sheet, allowing merchants to show a detailed breakdown of charges including subtotals, taxes, and discounts.
Motivation
Merchants need to display itemized pricing information in the Google Pay payment sheet to provide transparency to customers about what they're paying for. This feature enables showing individual line items alongside the total price.
Testing
Changelog