Skip to content

Commit 1a51675

Browse files
Remove stale SpecParser default comments from test-table-modes.ts (#144)
* Initial plan * Remove stale comments about SpecParser defaulting to RUNTIME_REQUIRED_TABLES Co-authored-by: kdhillon-stripe <243457111+kdhillon-stripe@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kdhillon-stripe <243457111+kdhillon-stripe@users.noreply.github.com>
1 parent 7ecb80b commit 1a51675

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

packages/sync-engine/scripts/test-table-modes.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,10 @@ async function main() {
3838
console.log(`Table names: ${runtimeRequiredSpec.tables.map((t) => t.tableName).join(', ')}`)
3939
console.log()
4040

41-
// Test all_projected mode (omit allowedTables per the interface documentation)
41+
// Test all_projected mode (omit allowedTables to parse all resolvable x-resourceId entries)
4242
const allProjectedSpec = parser.parse(resolvedSpec.spec, {
4343
resourceAliases: OPENAPI_RESOURCE_TABLE_ALIASES,
44-
// No allowedTables property - per types.ts: "If omitted, all resolvable x-resourceId entries are parsed"
45-
// Note: Current implementation defaults to RUNTIME_REQUIRED_TABLES when omitted
44+
// No allowedTables property - all resolvable x-resourceId entries are parsed
4645
})
4746

4847
console.log('=== all_projected mode ===')
@@ -67,12 +66,6 @@ async function main() {
6766
additionalTables.forEach((name) => console.log(` - ${name}`))
6867
} else {
6968
console.log('No additional tables found in all_projected mode.')
70-
console.log(
71-
'Note: The SpecParser defaults to RUNTIME_REQUIRED_TABLES when allowedTables is omitted.'
72-
)
73-
console.log(
74-
'This means the parser scope may be the actual bottleneck, not the migration filtering.'
75-
)
7669
}
7770
}
7871

0 commit comments

Comments
 (0)